8000 bpo-39496: Remove redundant checks from sqlite module's while loops by alexhenrie · Pull Request #18270 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-39496: Remove redundant checks from sqlite module's while loops #18270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2020
Merged

bpo-39496: Remove redundant checks from sqlite module's while loops #18270

merged 1 commit into from
Feb 1, 2020

Conversation

alexhenrie
Copy link
Contributor
@alexhenrie alexhenrie commented Jan 30, 2020 •
edited by bedevere-bot
Loading

This is a big win for code readability and it could also help performance.

https://bugs.python.org/issue39496

@alexhenrie alexhenrie force-pushed the sqlite-loops branch 3 times, most recently from 46a8b59 to 62e0b0f Compare February 1, 2020 07:14
@alexhenrie alexhenrie changed the title bpo-39496: Replace while loops with for loops to avoid redundant checks bpo-39496: Remove redundant checks from sqlite module's while loops Feb 1, 2020
berkerpeksag
berkerpeksag approved these changes Feb 1, 2020
View reviewed changes
Copy link
Member
@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@berkerpeksag berkerpeksag merged commit 78c7183 into python:master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexhenrie @berkerpeksag @the-knights-who-say-ni @bedevere-bot
0