8000 gh-58319: IDLE: Add interrupt handle when open debugger by mlouielu · Pull Request #1821 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-58319: IDLE: Add interrupt handle when open debugger #1821

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

gh-58319: IDLE: Add interrupt handle when open debugger #1821

wants to merge 8 commits into from

Conversation

mlouielu
Copy link
Contributor
@mlouielu mlouielu commented May 26, 2017 •
edited by bedevere-bot
Loading

@mention-bot
Copy link

@mlouielu, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kbkaiser, @terryjreedy and @ned-deily to be potential reviewers.

auvipy
auvipy approved these changes Jun 2, 2019
View reviewed changes
Copy link
@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase needed

@mlouielu mlouielu requested a review from terryjreedy as a code owner December 2, 2020 15:15
@roseman
Copy link
Contributor
roseman commented Dec 5, 2020

I'm wondering about the naming of the function "user_interrupt".

The other "user_*" functions ("user_line", "user_exception", etc.) are Bdb callbacks that allow the debugger to update itself based on the current state of the running program. In this case, we're actually trying to control the running program, and this routine is called by our own code, not Bdb.

The Bdb "set_" functions do control the running program, so we could consider "set_interrupt". The only potential downside is that it wouldn't be clear that this isn't a Bdb function. Perhaps something along the lines of "force_interrupt"?

I'm not normally super-pendantic about names, but with all the difference places where code is running in the debugger, it's hard enough to follow as it is, so anything that can be done in IDLE to avoid confusion is a good thing.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Feb 19, 2022
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 28, 2022
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Aug 28, 2022
iritkatriel
iritkatriel previously requested changes Nov 27, 2022
View reviewed changes
Copy link
Member
@iritkatriel iritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Nov 28, 2022
@terryjreedy
Copy link
Member

As with #15027, the merge conflict in run.py is because part of Executive.__init__ code was made conditional on not testing by #24302. I put the line added here, self.idb = None outside the condiition block as it should not interfere with other tests.

This PR also needs new tests.

@terryjreedy terryjreedy dismissed iritkatriel’s stale review November 28, 2022 04:53

Merge conflict fixed.

@python python deleted a comment from bedevere-bot Nov 28, 2022
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 29, 2022
@hauntsaninja hauntsaninja changed the title bpo-14111: IDLE: Add interrupt handle when open debugger gh-58319: IDLE: Add interrupt handle when open debugger Jan 7, 2023
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jan 8, 2023
@arhadthedev arhadthedev added stdlib Python modules in the Lib dir topic-IDLE labels Feb 4, 2023
@github-actions
Copy link
github-actions bot commented Mar 7, 2023

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auvipy auvipy auvipy approved these changes

@iritkatriel iritkatriel iritkatriel left review comments

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees
No one assigned
Labels
awaiting core review stale Stale PR or inactive for long period of time. stdlib Python modules in the Lib dir topic-IDLE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0