8000 [3.8] bpo-39235: Fix end location for genexp in call args (GH-17925) by miss-islington · Pull Request #17927 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.8] bpo-39235: Fix end location for genexp in call args (GH-17925) #17927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2020
Merged

[3.8] bpo-39235: Fix end location for genexp in call args (GH-17925) #17927

merged 1 commit into from
Jan 9, 2020

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Jan 9, 2020 •
edited by bedevere-bot
Loading

The fix changes copy_location() to require an extra node from which to extract the end location, and fixing all 5 call sites.

https://bugs.python.org/issue39235
(cherry picked from commit a796d8e)

Co-authored-by: Guido van Rossum guido@python.org

https://bugs.python.org/issue39235

@gvanrossum @miss-islington
bpo-39235: Fix end loca 8000 tion for genexp in call args (pythonGH-17925)
26bf99a 
The fix changes copy_location() to require an extra node from which to extract the end location, and fixing all 5 call sites.

https://bugs.python.org/issue39235
(cherry picked from commit a796d8e)

Co-authored-by: Guido van Rossum <guido@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Jan 9, 2020
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Jan 9, 2020
@miss-islington
Copy link
Contributor Author

@gvanrossum: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 33e033d into python:3.8 Jan 9, 2020
@miss-islington miss-islington deleted the backport-a796d8e-3.8 branch January 9, 2020 19:39
@miss-islington
Copy link
Contributor Author

@gvanrossum: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@gvanrossum: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @gvanrossum @the-knights-who-say-ni @bedevere-bot
0