8000 bpo-39220: Do not optimise annotation if 'from __future__ import annotations' is used by pablogsal · Pull Request #17866 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-39220: Do not optimise annotation if 'from __future__ import annotations' is used #17866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2020
Merged

bpo-39220: Do not optimise annotation if 'from __future__ import annotations' is used #17866

merged 2 commits into from
Mar 18, 2020

Conversation

pablogsal
Copy link
Member
@pablogsal pablogsal commented Jan 6, 2020 •
edited
Loading

@bedevere-bot bedevere-bot added the awaiting core review label Jan 6, 2020
@pablogsal pablogsal force-pushed the bpo-39220 branch 2 times, most recently from d254c04 to 3454862 Compare January 6, 2020 16:05
@pablogsal pablogsal requested a review from ambv January 6, 2020 23:17
@pablogsal pablogsal self-assigned this Jan 6, 2020
@pablogsal pablogsal requested a review from ilevkivskyi March 9, 2020 01:01
isidentical
isidentical approved these changes Mar 11, 2020
View reviewed changes
Copy link
Member
@isidentical isidentical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome.

pablogsal and others added 2 commits March 11, 2020 23:49
@pablogsal
Do not optimise annotation if 'from __future__ import annotations' is…
c05a1f3 
… used
@pablogsal @isidentical
Apply suggestions from code review
72d15e0 
Co-Authored-By: Batuhan Taşkaya <47358913+isidentical@users.noreply.github.com>
@pablogsal pablogsal merged commit d112c60 into python:master Mar 18, 2020
@pablogsal pablogsal deleted the bpo-39220 branch March 18, 2020 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isidentical isidentical isidentical approved these changes

@ambv ambv Awaiting requested review from ambv

@ilevkivskyi ilevkivskyi Awaiting requested review from ilevkivskyi

Assignees

@pablogsal pablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
38E3
4 participants
@pablogsal @isidentical @the-knights-who-say-ni @bedevere-bot
0