8000 [3.8] bpo-37685: Fixed __eq__, __lt__ etc implementations in some classes. (GH-14952) by serhiy-storchaka · Pull Request #17836 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

8000 [3.8] bpo-37685: Fixed __eq__, __lt__ etc implementations in some classes. (GH-14952) #17836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[3.8] bpo-37685: Fixed __eq__, __lt__ etc implementations in some classes. (GH-14952) #17836

wants to merge 1 commit into from

Conversation

serhiy-storchaka
Copy link
Member
@serhiy-storchaka serhiy-storchaka commented Jan 5, 2020 •
edited by bedevere-bot
Loading

They now return NotImplemented for unsupported type of the other operand.
(cherry picked from commit 662db12)

https://bugs.python.org/issue37685

@serhiy-storchaka
[3.8] bpo-37685: Fixed __eq__, __lt__ etc implementations in some cla…
176a341 
…sses. (pythonGH-14952)

They now return NotImplemented for unsupported type of the other operand..
(cherry picked from commit 662db12)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka requested a review from ambv January 5, 2020 14:45
@serhiy-storchaka serhiy-storchaka requested review from 1st1, asvetlov and a team as code owners January 5, 2020 14:45
@bedevere-bot bedevere-bot mentioned this pull request Jan 5, 2020
Merged
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting core review labels Jan 5, 2020
@serhiy-storchaka
Copy link
Member Author

@ambv please take a look.

@serhiy-storchaka serhiy-storchaka deleted the backport-662db12-3.8 branch February 12, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
6F08

@ambv ambv Awaiting requested review from ambv

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
awaiting core review type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
0