bpo-39068 guar 8000 d _b85chars2 initialization #17627
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Lib/base64.py
Outdated
| @@ -430,6 +430,7 @@ def b85encode(b, pad=False): | |||
| # if the function is never called | |||
| if _b85chars is None: | |||
There was a problem hiding this comment.
It is enough to check if _b85chars2 is None here.
These checks are cheap, but they are performed at every b85encode() call. Lesser checks is better.
a85encode() should be updated too. And may be other functions if they initialize two or more globals.
There was a problem hiding this comment.
done. visually scanned the file for other cases but only found the additional one in a85encode().
|
Please add a NEWS entry. Since it is your first contribution, add also your name in Misc/ACKS. |
|
Thank you for your contribution @drmonkeysee. Sorry for the delay, this ЗК fell out of my window of attention. |
|
Thanks @drmonkeysee for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
Thanks @drmonkeysee for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
There was a race condition in base64 in lazy initialization of multiple globals. (cherry picked from commit 9655434) Co-authored-by: Brandon Stansbury <brandonrstansbury@gmail.com>
|
GH-24020 is a backport of this pull request to the 3.9 branch. |
|
Sorry, @drmonkeysee and @serhiy-storchaka, I could not cleanly backport this to |
There was a race condition in base64 in lazy initialization of multiple globals.. (cherry picked from commit 9655434) Co-authored-by: Brandon Stansbury <brandonrstansbury@gmail.com>
|
GH-24022 is a backport of this pull request to the 3.8 branch. |
|
Thanks @drmonkeysee for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9. |
There was a race condition in base64 in lazy initialization of multiple globals. (cherry picked from commit 9655434) Co-authored-by: Brandon Stansbury <brandonrstansbury@gmail.com>
|
GH-24051 is a backport of this pull request to the 3.9 branch. |
There was a race condition in base64 in lazy initialization of multiple globals.
Under multi-threading scenarios a race condition may occur where a thread sees an initialized
_b85charstable but an uninitialized_b85chars2table due to the guard only checking the first table.This causes an exception like:
https://bugs.python.org/issue39068