8000 [3.7] bpo-37228: Fix warnings in test_asyncio.test_base_events (GH-17577) by miss-islington · Pull Request #17580 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.7] bpo-37228: Fix warnings in test_asyncio.test_base_events (GH-17577) #17580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2019
Merged

[3.7] bpo-37228: Fix warnings in test_asyncio.test_base_events (GH-17577) #17580

merged 1 commit into from
Dec 17, 2019

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Dec 12, 2019 •
edited by bedevere-bot
Loading

Co-authored-by: tirkarthi
(cherry picked from commit 1988344)

Co-authored-by: Kyle Stanley aeros167@gmail.com

https://bugs.python.org/issue37228

@aeros @miss-islington
Fix warnings in test_asyncio.test_base_events (pythonGH-17577)
e0afcd7 
Co-authored-by: tirkarthi
(cherry picked from commit 1988344)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
@bedevere-bot bedevere-bot mentioned this pull request Dec 12, 2019
Merged
@bedevere-bot bedevere-bot added skip news type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir awaiting review labels Dec 12, 2019
@ambv ambv changed the title [3.7] Fix warnings in test_asyncio.test_base_events (GH-17577) [3.7] bpo-37228: Fix warnings in test_asyncio.test_base_events (GH-17577) Dec 12, 2019
@ambv
Copy link
Contributor
ambv commented Dec 12, 2019

@aeros, this will need some help with merging as CI is failing.

@aeros
Copy link
Contributor
aeros commented Dec 12, 2019 •
edited
Loading

@ambv Based on the current build failure message from Travis, it looks like it's probably unrelated to the PR:

$ python --version

Python 3.6.9

$ pip --version

pip 19.3.1 from /home/travis/virtualenv/python3.6.9/lib/python3.6/site-packages/pip (python 3.6)
before_install.1

0.00s$ set -e

$ pyenv global 3.7.1

pyenv: version `3.7.1' not installed

@ambv
Copy link
Contributor
ambv commented Dec 12, 2019

Yes, it's pyenv related. #17579 has a similar problem. So if you want this in 3.8.1, that needs fixing.

@aeros
Copy link
Contributor
aeros commented Dec 12, 2019

@ambv Are you certain that it's an issue we can fix on our end? This seems identical to what @terryjreedy was experiencing a couple of weeks ago in https://mail.python.org/archives/list/python-dev@python.org/thread/YCTLWAYIC44YTVGNN4EDLWKMER2LAPDA/#YCTLWAYIC44YTVGNN4EDLWKMER2LAPDA, which led to Travis CI being temporarily disabled by @brettcannon as a requirement for merging PRs.

@miss-islington
Copy link
Contributor Author

@aeros and @ambv: Status check is done, and it's a failure ❌ .

@ambv
Copy link
Contributor
ambv commented Dec 12, 2019

The failure is caused by pyenv so it's not related to the change in this PR. We both agree on that. However, this makes us partially blind (Azure worked) and I would prefer to have CI run successfully before merging to 3.8.

@aeros
Copy link
Contributor
aeros commented Dec 12, 2019 •
edited
Loading

@ambv Oh I see. Sorry about that, I had misunderstood what you meant when you had said "So if you want this in 3.8.1, that needs fixing". I personally don't have experience with pyenv, so I was unsure of the exact cause of the CI failure or what the appropriate fix would be.

In the meantime, I'll work on the What's New entries (for the create_datagram_endpoint() security fix). I should have a PR open for those within the next couple of days.

@brettcannon
Copy link
Member

I'm going to assume I wasn't needed on this and unsubscribe. If I was wrong then just @ mention me again.

@terryjreedy
Copy link
Member

This is the same thing I saw before. If Travis is arbitrarily failing again, then it should be unrequired again or really fixed.

@ned-deily ned-deily merged commit c70c8ca into python:3.7 Dec 17, 2019
@miss-islington miss-islington deleted the backport-1988344-3.7 branch December 17, 2019 04:12
ned-deily pushed a commit to ned-deily/cpython that referenced this pull request Dec 18, 2019
@miss-islington @aeros @ned-deily
Fix warnings in test_asyncio.test_base_events (pythonGH-17577) (pytho…
9346209 
…nGH-17580)

Co-authored-by: tirkarthi
(cherry picked from commit 1988344)

Co-authored-by: Kyle Stanley <aeros167@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@miss-islington @ambv @aeros @brettcannon @terryjreedy @ned-deily @the-knights-who-say-ni @bedevere-bot
0