8000 bpo-37228: Fix loop.create_datagram_endpoint()'s usage of SO_REUSEADDR by aeros · Pull Request #17311 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-37228: Fix loop.create_datagram_endpoint()'s usage of SO_REUSEADDR #17311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 9, 2019
Merged

bpo-37228: Fix loop.create_datagram_endpoint()'s usage of SO_REUSEADDR #17311

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d748ca1
bpo-37228: Fix loop.create_datagram_endpoint()'s usage of SO_REUSEADDR
aeros Nov 21, 2019
69faa22
Formatting fix
aeros Nov 21, 2019
dea5eb3
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 21, 2019
a96fe61
Misc/NEWS formatting fix
aeros Nov 21, 2019
2cebb8d
Change RuntimeError to ValueError
aeros Nov 25, 2019
92cf301
Make description of security concern more explicit
aeros Nov 25, 2019
3292cb1
Minor Misc/NEWS improvement
aeros Nov 27, 2019
3146c7f
Fix alignment of ValueError string
aeros Dec 3, 2019
b83052e
Deprecate reuse_address=False
aeros Dec 3, 2019
f0e0369
Update tests
aeros Dec 3, 2019
f8b44ef
Add "Contributed by" to Misc/NEWS
aeros Dec 3, 2019
55314d8
Remove reuse_address from socket modifiers conditional
aeros Dec 3, 2019
dc521c5
Modify versionchanged to 3.8.1
aeros Dec 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Deprecate reuse_address=False 
Co-authored-by: Yury Selivanov <yury@edgedb.com>
  • Loading branch information
@aeros @1st1
aeros and 1st1 committed Dec 3, 2019
commit b83052e58d56e3e11c567b184992762b96ed97d4
24 changes: 17 additions & 7 deletions Lib/asyncio/base_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@
# Maximum timeout passed to select to avoid OS limitations
MAXIMUM_SELECT_TIMEOUT = 24 * 3600

# Used for deprecation and removal of `loop.create_datagram_endpoint()`'s
# *reuse_address* parameter
_unset = object()


def _format_handle(handle):
cb = handle._callback
Expand Down Expand Up @@ -1230,7 +1234,7 @@ async def start_tls(self, transport, protocol, sslcontext, *,
async def create_datagram_endpoint(self, protocol_factory,
local_addr=None, remote_addr=None, *,
family=0, proto=0, flags=0,
reuse_address=None, reuse_port=None,
reuse_address=_unset, reuse_port=None,
allow_broadcast=None, sock=None):
"""Create datagram connection."""
if sock is not None:
Expand Down Expand Up @@ -1306,12 +1310,18 @@ async def create_datagram_endpoint(self, protocol_factory,

exceptions = []

if reuse_address:
# bpo-37228
raise ValueError("Passing `reuse_address=True` is no "
"longer support 6871 ed, as the usage of "
"SO_REUSEPORT in UDP poses a significant "
"security concern.")
# bpo-37228
if reuse_address is not _unset:
if reuse_address:
raise ValueError("Passing `reuse_address=True` is no "
"longer supported, as the usage of "
"SO_REUSEPORT in UDP poses a significant "
"security concern.")
else:
warnings.warn("The *reuse_address* parameter has been "
"deprecated as of 3.5.10 and is scheduled "
"for removal in 3.11.", DeprecationWarning,
stacklevel=2)

for ((family, proto),
(local_address, remote_address)) in addr_pairs_info:
Expand Down
0