8000 bpo-38558: Mention `:=` in conditions tutorial. by ammaraskar · Pull Request #16919 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-38558: Mention := in conditions tutorial. 8000 #16919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2019
Merged

bpo-38558: Mention := in conditions tutorial. #16919

merged 2 commits into from
Oct 25, 2019

Conversation

ammaraskar
Copy link
Member
@ammaraskar ammaraskar commented Oct 24, 2019 •
edited by bedevere-bot
Loading

This mention about assignments is now stale with the introduction of the assignment expression operator. Adjust the wording to mention that := must be used explicitly, the rest of the paragraph explaining motivation still applies.

https://bugs.python.org/issue38558

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 24, 2019
@ammaraskar ammaraskar requested a review from aeros October 24, 2019 18:24
aeros
aeros reviewed Oct 24, 2019
View reviewed changes
Copy link
Contributor
@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @ammaraskar, this section of the tutorial should definitely be updated to mention the walrus operator for 3.8 and 3.9.

eamanu
eamanu approved these changes Oct 25, 2019
View reviewed changes
8000
Copy link
Contributor
@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after apply @aeros suggestion

@zware zware merged commit cb2cf06 into python:master Oct 25, 2019
@miss-islington
Copy link
Contributor

Thanks @ammaraskar for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@zware
Copy link
Member
zware commented Oct 25, 2019

Thanks for the patch!

@bedevere-bot
Copy link

GH-16926 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Oct 25, 2019
@miss-islington @ammaraskar
bpo-38558: Mention := in conditions tutorial (GH-16919)
cf028b5 
(cherry picked from commit cb2cf06)

Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
jacobneiltaylor pushed 8000 a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
@ammaraskar
bpo-38558: Mention := in conditions tutorial (pythonGH-16919)
c4b1d1f
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
@ammaraskar @shihai1991
bpo-38558: Mention := in conditions tutorial (pythonGH-16919)
318c5bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

@eamanu eamanu eamanu approved these changes

@aeros aeros aeros approved these changes

Assignees

@emilyemorehouse emilyemorehouse

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ammaraskar @miss-islington @zware @bedevere-bot @eamanu @aeros @emilyemorehouse @the-knights-who-say-ni
0