8000 [3.7] bpo-37531: regrtest ignores output on timeout (GH-16659) by miss-islington · Pull Request #16677 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.7] bpo-37531: regrtest ignores output on timeout (GH-16659) #16677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2019
Merged

[3.7] bpo-37531: regrtest ignores output on timeout (GH-16659) #16677

merged 1 commit into from
Oct 9, 2019

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Oct 9, 2019 •
edited by bedevere-bot
Loading

bpo-37531, bpo-38207: On timeout, regrtest no longer attempts to call
`popen.communicate() again: it can hang until all child processes
using stdout and stderr pipes completes. Kill the worker process and
ignores its output.

Reenable test_regrtest.test_multiprocessing_timeout().

bpo-37531: Change also the faulthandler timeout of the main process
from 1 minute to 5 minutes, for Python slowest buildbots.
(cherry picked from commit 0ec618a)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue37531

@vstinner @miss-islington
bpo-37531: regrtest ignores output on timeout (pythonGH-16659)
b610d87 
bpo-37531, bpo-38207: On timeout, regrtest no longer attempts to call
`popen.communicate() again: it can hang until all child processes
using stdout and stderr pipes completes. Kill the worker process and
ignores its output.

Reenable test_regrtest.test_multiprocessing_timeout().

bpo-37531: Change also the faulthandler timeout of the main process
from 1 minute to 5 minutes, for Python slowest buildbots.
(cherry picked from commit 0ec618a)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Oct 9, 2019
Merged
vstinner
vstinner approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 598bfa4 into python:3.7 Oct 9, 2019
@miss-islington miss-islington deleted the backport-0ec618a-3.7 branch October 9, 2019 13:52
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot
0