bpo-38360: macOS: support alternate form of -isysroot flag #16480
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
756fbd8 to
ddfb5b5
Compare
…16480) It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form.
|
(Ack) |
|
@ned-deily Ping. It would be nice to get this in to the 3.9.0 alphas. |
There was a problem hiding this comment.
Thanks, @jmroot, for the nice PR. Few are brave enough to enter those waters. In the interests of time, I took the liberty of pushing a few changes into the PR, namely extending a couple of existing test cases to cover the singe-argument case and a minor style nit.
|
Thanks @jmroot for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Thanks @jmroot for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
…16480) It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form. Co-authored-by: Ned Deily <nad@python.org> (cherry picked from commit b310700) Co-authored-by: Joshua Root <jmr@macports.org>
…16480) It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form. Co-authored-by: Ned Deily <nad@python.org> (cherry picked from commit b310700) Co-authored-by: Joshua Root <jmr@macports.org>
|
GH-19658 is a backport of this pull request to the 3.8 branch. |
|
GH-19657 is a backport of this pull request to the 3.7 branch. |
It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form. Co-authored-by: Ned Deily <nad@python.org> (cherry picked from commit b310700) Co-authored-by: Joshua Root <jmr@macports.org>
It is possible to use either '-isysroot /some/path' (with a space) or '-isysroot/some/path' (no space in between). Support both forms in places where special handling of -isysroot is done, rather than just the first form. Co-authored-by: Ned Deily <nad@python.org> (cherry picked from commit b310700) Co-authored-by: Joshua Root <jmr@macports.org>
It is possible to use either '-isysroot /some/path' or
'-isysroot/some/path' (no space in between). Support both forms in
places where special handling of -isysroot is done, rather than just
the first form.
https://bugs.python.org/issue38360