E52D bpo-38135: Fix depth-first-search computation in compile.c by markshannon · Pull Request #16042 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-38135: Fix depth-first-search computation in compile.c #16042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2019
Merged

bpo-38135: Fix depth-first-search computation in compile.c #16042

merged 1 commit into from
Sep 12, 2019

Conversation

@markshannon
Copy link
Member
@markshannon markshannon commented Sep 12, 2019 •
edited by bedevere-bot
Loading

With the current compiler it is impossible to expose the bug in the block ordering computation.
Consequently, there is no observable change in behavior and thus no news item is necessary.

https://bugs.python.org/issue38135

7440

@gpshead gpshead requested a review from Yhg1s September 12, 2019 13:05
gpshead
gpshead reviewed Sep 12, 2019
View reviewed changes
Copy link
Member
@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance I believe this is correct. Looping Thomas in as a reviewer as I believe he's been working in the compile code recently.

@gpshead gpshead added the sprint label Sep 12, 2019
@Yhg1s
Copy link
Member
Yhg1s commented Sep 12, 2019

I won't say "recently" (I looked at peephole.c the last couple of days, but not compile.c), but I'm familiar enough. The new code does look a lot more sensible than reversing twice.

@Yhg1s Yhg1s merged commit 355f3e1 into python:master Sep 12, 2019
Yhg1s added a commit that referenced this pull request Sep 12, 2019
@Yhg1s
Revert "Fix depth-first-search computation in compile.c (GH-16042)"
4aec4e9 
This reverts commit 355f3e1.
@Yhg1s Yhg1s mentioned this pull request Sep 12, 2019
Merged
gpshead pushed a commit that referenced this pull request Sep 12, 2019
@Yhg1s @gpshead
Revert "Fix depth-first-search computation in compile.c (GH-16042)" (G…
99b54d6 
…H-16050)

This reverts commit 355f3e1.

bpo-38135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead left review comments

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Assignees

No one assigned

Labels

skip news sprint

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@markshannon @Yhg1s @gpshead @the-knights-who-say-ni @bedevere-bot
0