8000 bpo-38133: Allow py.exe launcher to locate installations from the Microsoft Store by zooba · Pull Request #16025 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-38133: Allow py.exe launcher to locate installations from the Microsoft Store #16025

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2019
Merged

bpo-38133: Allow py.exe launcher to locate installations from the Microsoft Store #16025

merged 2 commits into from
Sep 12, 2019

Conversation

zooba
Copy link
Member
@zooba zooba commented Sep 12, 2019 •
edited by bedevere-bot
Loading

Also improve display of active virtual environments with --list options.

https://bugs.python.org/issue38133

@zooba
bpo-38133: Allow py.exe launcher to locate installations from the Mic…
8000
2caf5b3 
…rosoft Store and improve display of active virtual environments
@zooba zooba requested a review from a team as a code owner September 12, 2019 11:07
matrixise
matrixise approved these changes Sep 12, 2019
View reviewed changes
Copy link
Member
@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the source code, I don't find any problem, I am not a Win32 expert but the algos seem be okay.

@zooba
Copy link
Member Author
zooba commented Sep 12, 2019

The APIs themselves are fine (and easily testable), so if you're happy with the overall logic I'll merge and we can fix things up as they show up :)

@zooba zooba merged commit ed93a88 into python:master Sep 12, 2019
@zooba zooba deleted the bpo-38133 branch September 12, 2019 17:16
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @zooba, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker ed93a8852d120c5a3606720edc723bf5aa6a1fc2 3.8

@miss-islington
Copy link
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16073 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Sep 12, 2019
@miss-islington @zooba
bpo-38133: Allow py.exe launcher to locate installations from the Mic…
664d56a 
…rosoft Store (GH-16025)

(cherry picked from commit ed93a88)

Co-authored-by: Steve Dower <steve.dower@python.org>
@matrixise
Copy link
Member

I should try to find a VM of Windows and try to help you for the #windows bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrixise matrixise matrixise approved these changes

Assignees

@zooba zooba

Labels
OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zooba @miss-islington @bedevere-bot @matrixise @the-knights-who-say-ni
0