10000 Remove macOS tests from Travis. by benjaminp · Pull Request #15809 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

Remove macOS tests from Travis. #15809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Remove macOS tests from Travis. #15809

merged 1 commit into from
Sep 10, 2019

Conversation

benjaminp
Copy link
Contributor

Azure runs macOS, so we don't need Travis to do it.

Azure runs macOS, so we don't need Travis to do it.
@ammaraskar
Copy link
Member

Is overlap the only motivation for removal here? I don't think overlap is necessarily bad, after all we run Linux on both Travis and Azure as well. Windows is run on Azure and AppVeyor. The redundancy helps to figure out flaky tests/race conditions and provides some actionable information in case a particular provider goes down.

@benjaminp
Copy link
Contributor Author
benjaminp commented Sep 9, 2019 via email

@zooba
Copy link
Member
zooba commented Sep 10, 2019

I agree with this particular one, since the Travis resources are limited.

I'd prefer to keep as many parallel builds as we can though, especially cross-CI system, as that gives us better representation of different user environments.

@benjaminp benjaminp merged commit e45b217 into master Sep 10, 2019
@benjaminp benjaminp deleted the travis-macOS branch September 10, 2019 10:28
@miss-islington
Copy link
Contributor

Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15831 is a backport of this pull request to the 3.8 branch.

Copy link
Member
@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that running the tests under macOS on Travis has not proved to be very effective at finding real problems so I support making this change. Thanks!

miss-islington added a commit that referenced this pull request Sep 10, 2019
Azure runs macOS, so we don't need Travis to do it.
(cherry picked from commit e45b217)

Co-authored-by: Benjamin Peterson <benjamin@python.org>
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
Azure runs macOS, so we don't need Travis to do it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
0