8000 bpo-38047: don't add multi-arch paths if cross compiling. by hhb · Pull Request #15721 · python/cpython · GitHub
[go: up one dir, main page]

Skip to content

bpo-38047: don't add multi-arch paths if cross compiling. #15721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

bpo-38047: don't add multi-arch paths if cross compiling. #15721

wants to merge 1 commit into from

Conversation

hhb
Copy link
@hhb hhb commented Sep 7, 2019

This breaks cross compiling because unexpected host header paths are added.

https://bugs.python.org/issue38047

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" 8000 entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@hhb hhb changed the title Don't add multi-arch paths if cross compiling. bpo-38047: don't add multi-arch paths if cross compiling. Sep 7, 2019
@gpshead
Copy link
Member
gpshead commented Sep 10, 2019

This looks reasonable at a glance to me, but i'd like someone more familiar with the cross compiling vs multiarch as far as linux distros are concerned to take a look.

@gpshead gpshead requested a review from doko42 September 10, 2019 15:10
@gpshead gpshead removed their assignment Sep 10, 2019
@hhb hhb closed this Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0