8000 Fix unused variable and signed/unsigned warnings by rhettinger · Pull Request #15537 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Fix unused variable and signed/unsigned warnings #15537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 27, 2019
Merged

Fix unused variable and signed/unsigned warnings #15537

merged 6 commits into from
Aug 27, 2019

Conversation

rhettinger
Copy link
Contributor

@rhettinger rhettinger requested a review from pablogsal August 26, 2019 23:11
pablogsal
pablogsal reviewed Aug 26, 2019
View reviewed changes
Copy link
Member
@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @rhettinger for this 🎉

Just a couple of comments to fix the CI

pablogsal
pablogsal reviewed Aug 26, 2019
View reviewed changes
pablogsal
pablogsal reviewed Aug 26, 2019
View reviewed changes
@rhettinger rhettinger changed the title Fix unused variable warning Fix unused variable and signed/unsigned warnings Aug 27, 2019
serhiy-storchaka
serhiy-storchaka requested changes Aug 27, 2019
View reviewed changes
< 8000 /details-toggle>
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@pablogsal
Copy link
Member

Thanks, @rhettinger for the fix :)

@rhettinger rhettinger merged commit 0138c4c into python:master Aug 27, 2019
@rhettinger rhettinger deleted the fix_unused_warning branch August 27, 2019 16:55
@miss-islington
Copy link
Contributor

Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-15551 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 27, 2019
@rhettinger @miss-islington
Fix unused variable and signed/unsigned warnings (pythonGH-15537)
2892eef 
(cherry picked from commit 0138c4c)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
rhettinger added a commit that referenced this pull request Aug 27, 2019
@miss-islington @rhettinger
Fix unused variable and signed/unsigned warnings (GH-15537) (GH-15551)
d5ba8bb 
(cherry picked from commit 0138c4c)

Co-authored-by: Raymond Hettinger <rhettinger@users.noreply.github.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@rhettinger @lisroach
Fix unused variable and signed/unsigned warnings (pythonGH-15537)
8bc5c29
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@rhettinger @DinoV
Fix unused variable and signed/unsigned warnings (pythonGH-15537)
d4d4535
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@rhettinger @websurfer5
Fix unused variable and signed/unsigned warnings (pythonGH-15537)
d4749be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip issue skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development 3F88

Successfully merging this pull request may close these issues.
6 participants
@rhettinger @bedevere-bot @pablogsal @miss-islington @serhiy-storchaka @the-knights-who-say-ni
0