8000 bpo-30335: Add deprecation alias entry for assertNotRegexpMatches by DimitrisJim · Pull Request #1536 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-30335: Add deprecation alias entry for assertNotRegexpMatches #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2017
Merged

bpo-30335: Add deprecation alias entry for assertNotRegexpMatches #1536

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3c9eb6
Add deprecation alias entry for assertNotRegexpMatches
DimitrisJim May 10, 2017
31a90b2
Fix versionadded and deprecated directives
DimitrisJim May 12, 2017
b53f192
Revert previously removed versionadded for assertNotRegex().
DimitrisJim May 12, 2017
7cf3a6d
Adress review, 'as a' -> 'is a'
DimitrisJim May 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions Doc/library/unittest.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1170,6 +1170,9 @@ Test cases
:meth:`.assertRegex`.
.. versionadded:: 3.2
:meth:`.assertNotRegex`.
.. versionadded:: 3.5
The name ``assertNotRegexpMatches`` as a deprecated alias
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"as a" -> "is a"

for :meth:`.assertNotRegex`.


.. method:: assertCountEqual(first, second, msg=None)
Expand Down Expand Up @@ -1435,9 +1438,9 @@ For historical reasons, some of the :class:`TestCase` methods had one or more
aliases that are now deprecated. The following table lists the correct names
along with their deprecated aliases:

============================== ====================== ======================
============================== ====================== =======================
Method Name Deprecated alias Deprecated alias
============================== ====================== ======================
============================== ====================== =======================
:meth:`.assertEqual` failUnlessEqual assertEquals
:meth:`.assertNotEqual` failIfEqual assertNotEquals
:meth:`.assertTrue` failUnless assert\_
Expand All @@ -1446,17 +1449,19 @@ along with their deprecated aliases:
:meth:`.assertAlmostEqual` failUnlessAlmostEqual assertAlmostEquals
:meth:`.assertNotAlmostEqual` failIfAlmostEqual assertNotAlmostEquals
:meth:`.assertRegex` assertRegexpMatches
:meth:`.assertNotRegex` assertNotRegexpMatches
Copy link
Contributor
@marco-buttu marco-buttu May 12, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The assertNotRegexpMatches is not available for Python < 3.5, and we are saying that it has been deprecated in Python 3.2, when it was not available. IMHO we should not include this reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I changed that, after Brett's suggestion, to state it was introduced and deprecated at 3.5. It has to have an entry in this table so people who are porting testing code from 2 to 3 can see the new name for it.

:meth:`.assertRaisesRegex` assertRaisesRegexp
============================== ====================== ======================
============================== ====================== =======================

.. deprecated:: 3.1
the fail* aliases listed in the second column.
.. deprecated:: 3.2
the assert* aliases listed in the third column.
.. deprecated:: 3.2
``assertRegexpMatches`` and ``assertRaisesRegexp`` have been renamed to
:meth:`.assertRegex` and :meth:`.assertRaisesRegex`

:meth:`.assertRegex` and :meth:`.assertRaisesRegex`.
.. deprecated:: 3.5
the ``assertNotRegexpMatches`` name in favor of :meth:`.assertNotRegex`.

.. _testsuite-objects:

Expand Down
0