10000 gh-82005: Properly handle user input warnings in IDLE shell. by terryjreedy · Pull Request #15311 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-82005: Properly handle user input warnings in IDLE shell. #15311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

gh-82005: Properly handle user input warnings in IDLE shell. #15311

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
eb87bcd
bpo-37824: Properly handle user input warnings in IDLE shell.
terryjreedy Aug 16, 2019
be17e41
Revern warning_stream when Shell closes.
terryjreedy Aug 16, 2019
54edc23
Stop printing bogus prompt after warning.
terryjreedy Aug 16, 2019
73aaf87
Merge branch 'master' into warn
terryjreedy Aug 26, 2019
a82437d
Merge remote-tracking branch 'origin/master' into warn
terryjreedy Aug 26, 2019
12e292b
Merge remote-tracking branch 'origin/master' into warn
terryjreedy Aug 26, 2019
0fade74
Adjust test to changed warning format.
terryjreedy Aug 26, 2019
d45b1e0
Merge remote-tracking branch 'origin/warn' into warn
terryjreedy Aug 26, 2019
8d4d9bb
bpo-37309: Update IDLE NEWS.txt
terryjreedy May 24, 2020
83c713a
Merge remote-tracking branch 'upstream/master'
terryjreedy May 24, 2020
0ae61bc
Merge remote-tracking branch 'upstream/master'
terryjreedy May 25, 2020
b2ebe5c
Merge remote-tracking branch 'origin/master' into warn
terryjreedy May 25, 2020
a20cf7c
Show warnings once
csabella May 26, 2020
497298c
Merge remote-tracking branch 'upstream/master' into warn
terryjreedy May 28, 2020
b72612a
Merge branch 'warn' of https://github.com/terryjreedy/cpython into warn
terryjreedy May 28, 2020
d5849ad
Clean PyShell.runsource of unneeded assert and comments.
terryjreedy May 28, 2020
d250b71
Merge branch 'main' into warn
terryjreedy Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
D490
Prev Previous commit
Next Next commit
Stop printing bogus prompt after warning.
  • Loading branch information
@terryjreedy
terryjreedy committed Aug 16, 2019
commit 54edc239af51d8bf9791bf894616e393c68eeeb1
8 changes: 3 additions & 5 deletions Lib/idlelib/pyshell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,18 +67,16 @@

def idle_showwarning(
message, category, filename, lineno, file=None, line=None):
"""Show Idle-format warning (after replacing warnings.showwarning).
"""Print Idle-format warning to warning_stream.

The differences are the formatter called, the file=None replacement,
which can be None, the capture of the consequence AttributeError,
and the output of a hard-coded prompt.
Difference from show_warning are the formatter, the file=None
replacement, and the capture of the consequence AttributeError.
"""
if file is None:
file = warning_stream
try:
file.write(idle_formatwarning(
message, category, filename, lineno, line=line))
file.write(">>> ")
except (AttributeError, OSError):
pass # if file (probably __stderr__) is invalid, skip warning.

Expand Down
0