8000 bpo-21109: Add SafeTarFile by epicfaace · Pull Request #15244 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-21109: Add SafeTarFile #15244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

bpo-21109: Add SafeTarFile #15244

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7b28c5d
apply safetarfile-4.diff
epicfaace Aug 13, 2019
12a5074
doc: remove duplicate message
epicfaace Aug 13, 2019
a95ce6a
add TarFileTest and SafeTarFileTest
epicfaace Aug 13, 2019
a3bcc18
test: fix inheritance of tests to make it easier to extend
epicfaace Aug 13, 2019
2f8990d
add test inheritance of TarFileTest to all testcases
epicfaace Aug 13, 2019
769eb32
test: replace tarfile.open with tarfile_open
epicfaace Aug 13, 2019
8e522b4
test: replace tarfile.TarFile with self.tarfile_module
epicfaace Aug 13, 2019
8f361c1
test: make taropen generic
epicfaace Aug 13, 2019
b6862c6
Rename to -base because there's already a class called SafeTarFileTest
epicfaace Aug 13, 2019
bfe20da
Add some tests for SafeTarFile
epicfaace Aug 13, 2019
6011e26
test: move safetarfile to another test module
epicfaace Aug 13, 2019
18f7b30
keep only working safetarfile tests
epicfaace Aug 13, 2019
c58262b
add ustarreadtests
epicfaace Aug 13, 2019
b3fa18a
enable one failing safetarfile test
epicfaace Aug 13, 2019
14b88fe
Update tarfile.rst
epicfaace Mar 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add TarFileTest and SafeTarFileTest
  • Loading branch information
@epicfaace
epicfaace committed Aug 13, 2019
commit a95ce6ad92d7b404a1c488401a3c140cc851b14a
12 changes: 9 additions & 3 deletions Lib/test/test_tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,15 @@ def md5sum(data):
md5_regtype = "65f477c818ad9e15f7feab0c6d37742f"
md5_sparse = "a54fbc4ca4f4399a90e1b27164012fc6"

class TarFileTest:
tarfile_module = tarfile.TarFile
tarfile_open = tarfile.open
taropen = tarfile.TarFile.taropen

class SafeTarFileTest:
tarfile_module = tarfile.SafeTarFile
tarfile_open = tarfile.safe_open
taropen = tarfile.SafeTarFile.taropen

class TarTest:
tarname = tarname
Expand Down Expand Up @@ -451,15 +460,12 @@ def members(tar):
self.assertIn(b'ustar/regtype', out)
self.assertNotIn(b'ustar/conttype', out)


class GzipListTest(GzipTest, ListTest):
pass


class Bz2ListTest(Bz2Test, ListTest):
pass


class LzmaListTest(LzmaTest, ListTest):
pass

Expand Down
0