8000 bpo-37785: argparse uses %s in gettext calls causing xgettext warnings by kulikjak · Pull Request #15161 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-37785: argparse uses %s in gettext calls causing xgettext warnings #15161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2019
Merged

bpo-37785: argparse uses %s in gettext calls causing xgettext warnings #15161

merged 3 commits into from
Sep 13, 2019

Conversation

kulikjak
Copy link
Contributor
@kulikjak kulikjak commented Aug 7, 2019 •
edited by bedevere-bot
Loading

Running xgettext on argparse.py (of any currently supported Python 3.x) return following warning:

./Lib/argparse.py: warning: 'msgid' format string with unnamed arguments cannot be properly localized: The translator cannot reorder the arguments. Please consider using a format string with named arguments, and a mapping instead of a tuple for the arguments.

https://bugs.python.org/issue37785

CuriousLearner
CuriousLearner requested changes Aug 9, 2019
View reviewed changes
Copy link
Member
@CuriousLearner CuriousLearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor comment.

Overall looks good.

CuriousLearner
CuriousLearner reviewed Aug 9, 2019
View reviewed changes
@kulikjak @CuriousLearner
Minor improvements
30abc07 
Co-Authored-By: Sanyam Khurana <8039608+CuriousLearner@users.noreply.github.com>
CuriousLearner
CuriousLearner approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member
@CuriousLearner CuriousLearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just modify the NEWS entry. Overall looks good!

@kulikjak @CuriousLearner
Minor documentation fix
77c9863 
Co-Authored-By: Sanyam Khurana <8039608+CuriousLearner@users.noreply.github.com>
CuriousLearner
CuriousLearner approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member
@CuriousLearner CuriousLearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@kulikjak
Copy link
Contributor Author

LGTM

Thanks!

@JulienPalard JulienPalard merged commit 42671ae into python:master Sep 13, 2019
@miss-islington
Copy link
Contributor

Thanks @kulikjak for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-16080 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-16081 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 13, 2019
@kulikjak @miss-islington
bpo-37785: Fix xgettext warning in argparse (pythonGH-15161)
b67dfd6 
(cherry picked from commit 42671ae)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
miss-islington added a commit that referenced this pull request Sep 13, 2019
@miss-islington @kulikjak
bpo-37785: Fix xgettext warning in argparse (GH-15161)
b50eff6 
(cherry picked from commit 42671ae)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
miss-islington added a commit that referenced this pull request Sep 13, 2019
@miss-islington @kulikjak
bpo-37785: Fix xgettext warning in argparse (GH-15161)
8750dfe 
(cherry picked from commit 42671ae)

Co-authored-by: Jakub Kulík <Kulikjak@gmail.com>
JulienPalard added a commit that referenced this pull request Sep 13, 2019
@JulienPalard
Revert "bpo-37785: Fix xgettext warning in argparse (GH-15161)" (GH-1…
f14fcbf 
…6082)

This reverts commit b50eff6 because
it's an incompatible change that would have broken the existing
translations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CuriousLearner CuriousLearner CuriousLearner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kulikjak @miss-islington @bedevere-bot @CuriousLearner @JulienPalard @the-knights-who-say-ni
0