8000 bpo-37548: Document range of atan, acos and asin by potomak · Pull Request #14717 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-37548: Document range of atan, acos and asin #14717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 13, 2019
Merged

bpo-37548: Document range of atan, acos and asin #14717

merged 2 commits into from
Jul 13, 2019

Conversation

potomak
Copy link
Contributor
@potomak potomak commented Jul 12, 2019 •
edited by bedevere-bot
Loading

Document the range of the inverse trigonometric functions math.atan,
math.asin and math.acos.

https://bugs.python.org/issue37548

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 12, 2019
@potomak potomak force-pushed the issue37548 branch 2 times, most recently from 8538781 to 400f434 Compare July 12, 2019 03:22
mdickinson
mdickinson reviewed Jul 12, 2019
View reviewed changes
mdickinson
mdickinson suggested changes Jul 12, 2019
View reviewed changes
Copy link
Member
@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick; apart from that, LGTM. Thank you!

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

ZackerySpytz
ZackerySpytz reviewed Jul 12, 2019
View reviewed changes
@potomak
bpo-37548: Document range of atan, acos and asin
1d20f28 
Document the range of the inverse trigonometric functions `math.atan`,
`math.asin` and `math.acos`.
@potomak
Copy link
Contributor Author
potomak commented Jul 13, 2019 •
edited
Loading

@mdickinson not a blocker, but I didn't notice 29be072 and accidentally overwritten it (commit --amend + push -f). I'm not sure why, but I can't find a way to recover it from either upstream nor origin.

@mdickinson
Copy link
Member

@potomak No problem; I've re-applied that commit. In general there's not much benefit to force-pushing for PRs against this repository: everything gets squashed at merge time anyway. (More information on this in the dev-guide.)

@mdickinson mdickinson self-requested a review July 13, 2019 13:40
mdickinson
mdickinson approved these changes Jul 13, 2019
View reviewed changes
Copy link
Member
@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@potomak
Copy link
Contributor Author
potomak commented Jul 13, 2019

@mdickinson

No problem; I've re-applied that commit.

Thanks :)

In general there's not much benefit to force-pushing for PRs against this repository: everything gets squashed at merge time anyway.

Good to know, thanks for the info. I will review the dev-guide more carefully.

@mdickinson mdickinson merged commit dc3f99f into python:master Jul 13, 2019
@potomak potomak deleted the issue37548 branch July 16, 2019 02:15
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@potomak @lisroach
bpo-37548: Document range of atan, acos and asin (pythonGH-14717)
1f6ca9a
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@potomak @DinoV
bpo-37548: Document range of atan, acos and asin (pythonGH-14717)
9cf367f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

@mdickinson mdickinson mdickinson approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@potomak @bedevere-bot @mdickinson @ZackerySpytz @the-knights-who-say-ni
0