8000 bpo-37513: Fix a type error in ctypes.rst by shihai1991 · Pull Request #14615 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-37513: Fix a type error in ctypes.rst #14615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2019
Merged

bpo-37513: Fix a type error in ctypes.rst #14615

merged 1 commit into from
Jul 7, 2019

Conversation

shihai1991
Copy link
Member
@shihai1991 shihai1991 commented Jul 6, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jul 6, 2019
aeros
aeros approved these changes Jul 6, 2019
View reviewed changes
Copy link
Contributor
@aeros aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shihai1991 Thanks for the contribution! Verified that POINT(1, 2, 3) causes a TypeError instead of a ValueError:
image

@shihai1991
Copy link
Member Author

@shihai1991 Thanks for the contribution! Verified that POINT(1, 2, 3) causes a TypeError instead of a ValueError:
image

Thanks for review and verify :)

@zhangyangyu zhangyangyu merged commit f6cdd3f into python:master Jul 7, 2019
@miss-islington
Copy link
Contributor

Thanks @shihai1991 for the PR, and @zhangyangyu for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

GH-14635 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-14636 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2019
@shihai1991 @miss-islington
bpo-37513: Change ValueError to TypeError in an example in ctypes doc (…
783f9d7 
…pythonGH-14615)

(cherry picked from commit f6cdd3f)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2019
@shihai1991 @miss-islington
bpo-37513: Change ValueError to TypeError in an example in ctypes doc (…
5df2bb5 
…pythonGH-14615)

(cherry picked from commit f6cdd3f)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
miss-islington added a commit that referenced this pull request Jul 7, 2019
@miss-islington @shihai1991
bpo-37513: Change ValueError to TypeError in an example in ctypes doc (…
bc0a6ce 
…GH-14615)

(cherry picked from commit f6cdd3f)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
miss-islington added a commit that referenced this pull request Jul 7, 2019
@miss-islington @shihai1991
bpo-37513: Change ValueError to TypeError in an example in ctypes doc (…
3f7d0c9 
…GH-14615)

(cherry picked from commit f6cdd3f)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
@miss-islington
Copy link
Contributor

Thanks @shihai1991 for the PR, and @zhangyangyu for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-14637 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2019
@shihai1991 @miss-islington
bpo-37513: Change ValueError to TypeError in an example in ctypes doc (…
2639337 
…pythonGH-14615)

(cherry picked from commit f6cdd3f)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
miss-islington added a commit that referenced this pull request Jul 7, 2019
@miss-islington @shihai1991
bpo-37513: Change ValueError to TypeError in an example in ctypes doc (…
00bf4d6 
…GH-14615)

(cherry picked from commit f6cdd3f)

Co-authored-by: Hai Shi <shihai1992@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@shihai1991 @lisroach
bpo-37513: Change ValueError to TypeError in an example in ctypes doc (…
ee238c8 
…pythonGH-14615)
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@shihai1991 @DinoV
bpo-37513: Change ValueError to TypeError in an example in ctypes doc (…
7749ff8 
…pythonGH-14615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangyangyu zhangyangyu zhangyangyu approved these changes

@aeros aeros aeros approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shihai1991 @miss-islington @bedevere-bot @zhangyangyu @aeros @the-knights-who-say-ni
0