10000 [3.8] bpo-37421: test_concurrent_futures cleans up multiprocessing (GH-14563) by miss-islington · Pull Request #14570 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.8] bpo-37421: test_concurrent_futures cleans up multiprocessing (GH-14563) #14570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

[3.8] bpo-37421: test_concurrent_futures cleans up multiprocessing (GH-14563) #14570

merged 1 commit into from
Jul 3, 2019

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Jul 3, 2019 •
edited by bedevere-bot
Loading

test_concurrent_futures now cleans up multiprocessing to remove
immediately temporary directories created by
multiprocessing.util.get_temp_dir().

The test now uses setUpModule() and tearDownModule().
(cherry picked from commit 684cb47)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue37421

@vstinner @miss-islington
bpo-37421: test_concurrent_futures cleans up multiprocessing (pythonG…
2482aca 
…H-14563)

test_concurrent_futures now cleans up multiprocessing to remove
immediately temporary directories created by
multiprocessing.util.get_temp_dir().

The test now uses setUpModule() and tearDownModule().
(cherry picked from commit 684cb47)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot bedevere-bot mentioned this pull request Jul 3, 2019
Merged
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jul 3, 2019
vstinner
vstinner approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 79665c6 into python:3.8 Jul 3, 2019
@miss-islington miss-islington deleted the backport-684cb47-3.8 branch July 3, 2019 09:36
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot
0