-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
gh-143414: Implement unique reference tracking for JIT, optimize unpacking of such tuples #144300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
reidenong
wants to merge
28
commits into
python:main
Choose a base branch
from
reidenong:branch-unique-reference-tracking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,294
−874
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
e4b7f51
Add unique reference tracking to JIT, optimize tuple unpacking
reidenong b32a8e2
Merge branch 'main' into branch-unique-reference-tracking
reidenong 7aeac0e
Regenerate cases
reidenong f8b7e4e
Fix unique tuple unpacking checks
reidenong 37d7c4b
Implement _PyTuple_ExactDealloc
reidenong 7df2176
Rename symbol
reidenong 6f66c56
Merge branch 'main' into branch-unique-reference-tracking
reidenong b251825
Merge branch 'main' into branch-unique-reference-tracking
reidenong bcd5654
Regenerate cases
reidenong acfa737
Add alignment checking
reidenong a0fd9e2
Change JIT reference tags to 2 bit scheme
reidenong 645776a
📜🤖 Added by blurb_it.
blurb-it[bot] cdb4a05
Fix style
reidenong 275732b
Remove unnecesssary deopt
reidenong dbde059
Regenerate cases
reidenong bd70ebd
Replace tuple deallocation with tuple free
reidenong d16f298
Merge branch 'main' into branch-unique-reference-tracking
reidenong bec7ee3
Regenerate cases
reidenong 5c9b9c6
Add unique reference two tuple optimization
reidenong cdbe2e6
Add efficient unpacking for uniquely referenced three tuples
reidenong fb1d227
Move length checks to JIT
reidenong c7e53fb
Refactor JIT reference remove unique
reidenong 6851962
Remove JIT reference uniqueness on store
reidenong 8c8e0a9
Remove unnecessary DEOPT
reidenong a6fffdc
Remove redundant make unique ops
reidenong 78978aa
Merge branch 'main' into branch-unique-reference-tracking
reidenong 0b07ac4
Regen cases
reidenong 14e5d3d
Merge branch 'main' into branch-unique-reference-tracking
reidenong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Implement _PyTuple_ExactDealloc
- Loading branch information
commit 37d7c4b8cff12b4a9935b7ca0dd0aa24dfb59787
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we free the tuple directly, we don't need to
NULLout the fields.