8000 [3.8] bpo-37421: Fix test_shutil: don't leak temporary files (GH-14416) by miss-islington · Pull Request #14417 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

[3.8] bpo-37421: Fix test_shutil: don't leak temporary files (GH-14416) #14417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2019
Merged

[3.8] bpo-37421: Fix test_shutil: don't leak temporary files (GH-14416) #14417

merged 1 commit into from
Jun 26, 2019

Conversation

miss-islington
Copy link
Contributor
@miss-islington miss-islington commented Jun 26, 2019 •
edited by bedevere-bot
Loading
  • Fix typo in supports_file2file_sendfile(); ensure that dst is
    removed
  • Fix test_copytree_custom_copy_function(): remove dst tree.
    Use support.rmtree() rather than shutil.rmtree() to remove
    temporary directories: support tries harder.
    (cherry picked from commit 4c26abd)

Co-authored-by: Victor Stinner vstinner@redhat.com

https://bugs.python.org/issue37421

@vstinner @miss-islington
bpo-37421: Fix test_shutil: don't leak temporary files (pythonGH-14416)
2c91432 
* Fix typo in supports_file2file_sendfile(); ensure that dst is
  removed
* Fix test_copytree_custom_copy_function(): remove dst tree.
  Use support.rmtree() rather than shutil.rmtree() to remove
  temporary directories: support tries harder.
(cherry picked from commit 4c26abd)

Co-authored-by: Victor Stinner <vstinner@redhat.com>
@bedevere-bot bedevere-bot mentioned this pull request Jun 26, 2019
Merged
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jun 26, 2019
vstinner
vstinner approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member
@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 7fe81ce into python:3.8 Jun 26, 2019
@miss-islington miss-islington deleted the backport-4c26abd-3.8 branch June 26, 2019 23:57
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot
0