8000 bpo-36889: Replace deprecation warning with RuntimeError by asvetlov · Pull Request #14397 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-36889: Replace deprecation warning with RuntimeError #14397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

bpo-36889: Replace deprecation warning with RuntimeError #14397

merged 1 commit into from
Jun 27, 2019

Conversation

asvetlov
Copy link
Contributor
@asvetlov asvetlov commented Jun 26, 2019 •
edited by bedevere-bot
Loading

asyncio.Stream is a new class, there is no reason for deprecation period

https://bugs.python.org/issue36889

@asvetlov asvetlov requested a review from 1st1 as a code owner June 26, 2019 15:25
eamanu
eamanu approved these changes Jun 26, 2019
View reviewed changes
Copy link
Contributor
@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tirkarthi
tirkarthi approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member
@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@asvetlov asvetlov merged commit 97d15b1 into python:master Jun 27, 2019
@miss-islington
Copy link
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2019
@asvetlov @miss-islington
Replace deprecation warning with RuntimeError (pythonGH-14397)
9b332df 
(cherry picked from commit 97d15b1)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@bedevere-bot
Copy link

GH-14422 is a backport of this pull request to the 3.8 branch.

@asvetlov asvetlov deleted the stricter-check branch June 27, 2019 11:39
miss-islington added a commit that referenced this pull request Jun 27, 2019
@miss-islington @asvetlov
Replace deprecation warning with RuntimeError (GH-14397)
4cbe7a3 
(cherry picked from commit 97d15b1)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@asvetlov @lisroach
Replace deprecation warning with RuntimeError (pythonGH-14397)
da42d79
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@asvetlov @DinoV
Replace deprecation warning with RuntimeError (pythonGH-14397)
6089829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tirkarthi tirkarthi tirkarthi approved these changes

@eamanu eamanu eamanu approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
skip news topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@asvetlov @miss-islington @bedevere-bot @tirkarthi @eamanu @the-knights-who-say-ni
0