8000 Make code coverage less strict by brettcannon · Pull Request #1438 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Make code coverage less strict #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2017
Merged

Make code coverage less strict #1438

merged 1 commit into from
May 4, 2017

Conversation

brettcannon
Copy link
Member

Set the target to be 90% -- since there is enough OS-specific code and things that require manual testing that we will never hit 100% -- and turn off the status checks since they are so inconsistent in terms of flagging a PR as passing/failing.

Closes python/core-workflow#75 and python/core-workflow#76 .

@brettcannon
Make code coverage less strict
5df9659 
Set the target to be 90% -- since there is enough OS-specific code and things that require manual testing that we will never hit 100% -- and turn off the status checks since they are so inconsistent in terms of flagging a PR as passing/failing.
@brettcannon brettcannon self-assigned this May 3, 2017
@brettcannon brettcannon merged commit 647c3d3 into master May 4, 2017
@brettcannon brettcannon deleted the loosen-code-coverage branch May 4, 2017 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

@brettcannon brettcannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brettcannon @vstinner @the-knights-who-say-ni
0