8000 bpo-35621: Support running subprocesses in asyncio when loop is executed in non-main thread by asvetlov · Pull Request #14344 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-35621: Support running subprocesses in asyncio when loop is executed in non-main thread #14344

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 30, 2019
Merged

bpo-35621: Support running subprocesses in asyncio when loop is executed in non-main thread #14344

Changes from 2 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
3695efd
Close pid waiters on watcher.close()
asvetlov Jun 3, 2019
3559581
Revert "Revert "bpo-35621: Support running subprocesses in asyncio wh…
asvetlov Jun 4, 2019
b18e6b9
Merge branch 'dangling-threads-in-watcher' into threaded-waiter
asvetlov Jun 4, 2019
1bc1d8e
Merge remote-tracking branch 'upstream/master' into threaded-waiter
asvetlov Jun 4, 2019
ef1e21c
Work on
asvetlov Jun 4, 2019
c982e4a
Merge branch 'master' into threaded-waiter
asvetlov Jun 24, 2019
6912ec7
Fix dangling thread warnings in tests
asvetlov Jun 24, 2019
efb19c0
Update documentation
asvetlov Jun 24, 2019
eb07403
Add docstrings
asvetlov Jun 25, 2019
6aa3357
Update Doc/library/asyncio-policy.rst
asvetlov Jun 30, 2019
25d9ac2
Fix doc text
asvetlov Jun 30, 2019
ae3a706
Update Doc/library/asyncio-policy.rst
asvetlov Jun 30, 2019
8baf48c
Update Doc/library/asyncio-policy.rst
asvetlov Jun 30, 2019
6e6a783
Update Doc/library/asyncio-policy.rst
asvetlov Jun 30, 2019
1e1281a
Update Lib/asyncio/unix_events.py
asvetlov Jun 30, 2019
936aeb0
Update Lib/asyncio/unix_events.py
asvetlov Jun 30, 2019
cc5a752
Update docs
asvetlov Jun 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Lib/asyncio/unix_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1230,12 +1230,15 @@ class ThreadedChildWatcher(AbstractChildWatcher):

def __init__(self):
self._pid_counter = itertools.count(0)
self._threads = {}

def is_active(self):
return True

def close(self):
pass
threads = list(self._threads.values())
for thread in threads:
thread.join()

def __enter__(self):
return self
Expand All @@ -1249,6 +1252,7 @@ def add_child_handler(self, pid, callback, *args):
name=f"waitpid-{next(self._pid_counter)}",
args=(loop, pid, callback, args),
daemon=True)
self._threads[pid] = thread
thread.start()

def remove_child_handler(self, pid):
Expand Down Expand Up @@ -1284,6 +1288,8 @@ def _do_waitpid(self, loop, expected_pid, callback, args):
else:
loop.call_soon_threadsafe(callback, pid, returncode, *args)

self._threads.pop(expected_pid)


class _UnixDefaultEventLoopPolicy(events.BaseDefaultEventLoopPolicy):
"""UNIX event loop policy with a watcher for child processes."""
Expand Down
0