bpo-37347: fix refcount problem in sqlite3 #14268
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a61d42 to
6d75038
Compare
benjaminp
reviewed
Jun 26, 2019
Lib/sqlite3/test/regression.py
Outdated
| log = printer_instance.log | ||
| refcnt_before = sys.getrefcount(log) | ||
| method(log) | ||
| refcnt_after = sys.getrefcount(log) |
There was a problem hiding this comment.
We should try to avoid writing tests that use sys.getrefcount. Does this test fail if you pass -R :: to regrtest.py?
There was a problem hiding this comment.
Nope. But it can be rewritten to fall to segmentation fault.
There was a problem hiding this comment.
Sounds good to me. Not crashing is the behavior we want to test anyway.
There was a problem hiding this comment.
Then it is done in d1b57ff.
|
Thanks @gescheit for the PR, and @benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-14725 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 13, 2019
(cherry picked from commit b9a0376) Co-authored-by: gescheit <gescheit@yandex-team.ru>
miss-islington
added a commit
that referenced
this pull request
Jul 13, 2019
coleifer
added a commit
to coleifer/pysqlite3
that referenced
this pull request
Jul 22, 2019
coleifer
added a commit
to coleifer/sqlcipher3
that referenced
this pull request
Jul 22, 2019
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix refcount problem in sqlite3
https://bugs.python.org/issue37347