8000 Update weakref.rst by geryogam · Pull Request #14098 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

Update weakref.rst #14098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2019
Merged

Update weakref.rst #14098

merged 2 commits into from
Jun 15, 2019

Conversation

geryogam
Copy link
Contributor

No description provided.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jun 15, 2019
mangrisano
mangrisano suggested changes Jun 15, 2019
View reviewed changes
@mangrisano
Copy link
Contributor

Hi, thank you for the pull request.

I've left a suggestion about the change.

Thank you. :)

csabella
csabella approved these changes Jun 15, 2019
View reviewed changes
Copy link
Contributor
@csabella csabella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@miss-islington
Copy link
Contributor

@maggyero: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor

@maggyero: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit f475729 into python:master Jun 15, 2019
@miss-islington
Copy link
Contributor

Thanks @maggyero for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-14105 is a backport of this pull request to the 3.8 branch.

@bedevere-bot
Copy link

GH-14106 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2019
@geryogam @miss-islington
Update weakref.rst (pythonGH-14098)
315e914 
(cherry picked from commit f475729)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@csabella
Copy link
Contributor

Thanks for the PR @maggyero and for the review @mangrisano. 🎉

miss-islington added a commit that referenced this pull request Jun 15, 2019
@miss-islington @geryogam
Update weakref.rst (GH-14098)
6887814 
(cherry picked from commit f475729)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
miss-islington added a commit that referenced this pull request Jun 15, 2019
@miss-islington @geryogam
Update weakref.rst (GH-14098)
30cac20 
(cherry picked from commit f475729)

Co-authored-by: Géry Ogam <gery.ogam@gmail.com>
@geryogam geryogam deleted the patch-7 branch June 15, 2019 17:27
@geryogam
Copy link
Contributor Author

Thank you for the review @csabella and @mangrisano.

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@geryogam @lisroach
Update weakref.rst (pythonGH-14098)
9f46277
This was referenced Sep 12, 2019
Merged
Merged
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@geryogam @DinoV
Update weakref.rst (pythonGH-14098)
2e980c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mangrisano mangrisano mangrisano requested changes

@csabella csabella csabella approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@geryogam @mangrisano @miss-islington @bedevere-bot @csabella @the-knights-who-say-ni
0