8000 bpo-37280: Use threadpool for reading from file in sendfile fallback mode by asvetlov · Pull Request #14076 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-37280: Use threadpool for reading from file in sendfile fallback mode #14076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2019
Merged

bpo-37280: Use threadpool for reading from file in sendfile fallback mode #14076

merged 1 commit into from
Jun 15, 2019

Conversation

asvetlov
Copy link
Contributor
@asvetlov asvetlov commented Jun 14, 2019 •
edited
Loading

We do it for loop.sock_sendfile(), there is no reason to call blocking code for loop.sendfile()

https://bugs.python.org/issue37280

@asvetlov asvetlov requested a review from 1st1 as a code owner June 14, 2019 10:32
@asvetlov asvetlov merged commit 0237265 into python:master Jun 15, 2019
@bedevere-bot
Copy link

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @asvetlov, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0237265e8287141c40faa8719da3a2d21d511d0d 3.8

@bedevere-bot
Copy link

GH-14101 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 15, 2019
@asvetlov @miss-islington
Use threadpool for reading from file in sendfile fallback mode (pytho…
2017f63 
…nGH-14076)

(cherry picked from commit 0237265)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit to asvetlov/cpython that referenced this pull request Jun 15, 2019
@asvetlov
[3.8] Use threadpool for reading from file in sendfile fallback mode (p…
acff6c2 
…ythonGH-14076)

(cherry picked from commit 0237265)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@bedevere-bot
Copy link

GH-14102 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 15, 2019
@miss-islington @asvetlov
Use threadpool for reading from file in sendfile fallback mode (GH-14076
5e97450 
)

(cherry picked from commit 0237265)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit that referenced this pull request Jun 15, 2019
@asvetlov
[3.8] Use threadpool for reading from file in sendfile fallback mode (G…
b6ff2cd 
…H-14076) (GH-14102)

(cherry picked from commit 0237265)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@asvetlov @lisroach
Use threadpool for reading from file in sendfile fallback mode (pytho…
9bb3412 
…n#14076)
@asvetlov asvetlov deleted the read-in-threadpool branch September 12, 2019 12:42
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@asvetlov @DinoV
Use threadpool for reading from file in sendfile fallback mode (pytho…
88d9dc 6FFB 4 
…n#14076)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 Awaiting requested review from 1st1

Assignees

@asvetlov asvetlov

Labels
topic-asyncio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asvetlov @bedevere-bot @miss-islington @the-knights-who-say-ni
0