8000 gh-139847: Add PyType_Lookup() function by vstinner · Pull Request #139848 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-139847: Add PyType_Lookup() function#139848

Open
vstinner wants to merge 9 commits intopython:mainfrom
vstinner:type_lookup
Open

gh-139847: Add PyType_Lookup() function#139848
vstinner wants to merge 9 commits intopython:mainfrom
vstinner:type_lookup

Conversation

@vstinner
Copy link
Member
@vstinner vstinner commented Oct 9, 2025 •
edited by github-actions bot
Loading

@vstinner vstinner added type-feature A feature request or enhancement interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-C-API labels Oct 9, 2025
@bedevere-app bedevere-app bot mentioned this pull request Oct 9, 2025
Open
@vstinner vstinner removed the type-feature A feature request or enhancement label Oct 9, 2025
colesbury
colesbury reviewed Oct 9, 2025
View reviewed changes
vstinner and others added 2 commits October 9, 2025 20:49
@vstinner @colesbury
Update Doc/c-api/type.rst
1c3e523 
Co-authored-by: Sam Gross <colesbury@gmail.com>
@vstinner
Doc: link to PyObject_GetOptionalAttr()
8f24f7a
@vstinner vstinner added type-feature A feature request or enhancement awaiting merge labels Oct 9, 2025
@vstinner
Copy link
Member Author
vstinner commented Oct 9, 2025

Check labels / Unresolved review (pull_request): Failing after 6s

The CI fails with:

Error: Label error. Requires exactly 1 of: awaiting merge. Found: type-feature, awaiting core review, interpreter-core, topic-C-API

I added the awaiting merge label to repair this CI.

efimov-mikhail
efimov-mikhail reviewed Oct 11, 2025
View reviewed changes
efimov-mikhail
efimov-mikhail reviewed Oct 11, 2025
View reviewed changes
@vstinner
Copy link
Member Author
vstinner commented Oct 11, 2025

I reverted changes to schedule _PyType_Lookup() and _PyType_LookupRef() removal, just to make this PR easier to review and more "atomic". I prefer to write a separated PR for the removal.

@vstinner
Copy link
Member Author
vstinner commented Oct 14, 2025

@encukou: So what do you think of exposing this PyType function?

@encukou
Copy link
Member
encukou commented Oct 14, 2025

I think there's benefit to exposing this but we need to do it carefully. The operation is different from getattr in surprising ways. The docs & tests should mention details -- not invoking descriptors or metaclass getattr. It might also be good for the docs to add an example of where Python uses this operaton, and/or equivalent Python code.

“Lookup” is a new term in the public C API; are we sure this is the right operation for the name?

@vstinner
Do not invoke descriptors or metaclass __getattr__()
1290171 
Add Python pseudo-code in the doc.
@vstinner
Copy link
Member Author
vstinner commented Oct 14, 2025

The docs & tests should mention details -- not invoking descriptors or metaclass getattr.

Good idea. I added tests for that and completed the doc.

It might also be good for the docs to add an example of where Python uses this operaton, and/or equivalent Python code.

I added Python pseudo-code to the doc.

@vstinner vstinner mentioned this pull request Oct 16, 2025
Open
5 tasks
encukou
encukou reviewed Jan 13, 2026
View reviewed changes
@vstinner @encukou
Update Doc/c-api/type.rst
2cc877c 
Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

@colesbury colesbury colesbury left review comments

@efimov-mikhail efimov-mikhail efimov-mikhail left review comments

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

No one assigned

Labels

awaiting core review awaiting merge interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-C-API type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @encukou @colesbury @efimov-mikhail
0