bpo-12144: Handle cookies with expires attribute in CookieJar.make_cookies #13921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Demian Brecht <demianbrecht@gmail.com>
mangrisano
approved these changes
Jun 12, 2019
|
Thanks @tirkarthi for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8. |
|
GH-16088 is a backport of this pull request to the 3.8 branch. |
|
GH-16089 is a backport of this pull request to the 3.7 branch. |
|
Sorry, @tirkarthi, I could not cleanly backport this to |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 13, 2019
…okies (pythonGH-13921) Handle time comparison for cookies with `expires` attribute when `CookieJar.make_cookies` is called. Co-authored-by: Demian Brecht <demianbrecht@gmail.com> https://bugs.python.org/issue12144 Automerge-Triggered-By: @asvetlov (cherry picked from commit bb41147) Co-authored-by: Xtreak <tir.karthi@gmail.com>
miss-islington
added a commit
that referenced
this pull request
Sep 13, 2019
…okies (GH-13921) Handle time comparison for cookies with `expires` attribute when `CookieJar.make_cookies` is called. Co-authored-by: Demian Brecht <demianbrecht@gmail.com> https://bugs.python.org/issue12144 Automerge-Triggered-By: @asvetlov (cherry picked from commit bb41147) Co-authored-by: Xtreak <tir.karthi@gmail.com>
tirkarthi
added a commit
to tirkarthi/cpython
that referenced
this pull request
Sep 13, 2019
…ake_cookies (pythonGH-13921) Handle time comparison for cookies with `expires` attribute when `CookieJar.make_cookies` is called. Co-authored-by: Demian Brecht <demianbrecht@gmail.com> https://bugs.python.org/issue12144 Automerge-Triggered-By: @asvetlov (cherry picked from commit bb41147) Co-authored-by: Xtreak <tir.karthi@gmail.com>
tirkarthi
added a commit
to tirkarthi/cpython
that referenced
this pull request
Sep 13, 2019
…ake_cookies (pythonGH-13921) Handle time comparison for cookies with `expires` attribute when `CookieJar.make_cookies` is called. Co-authored-by: Demian Brecht <demianbrecht@gmail.com> https://bugs.python.org/issue12144 Automerge-Triggered-By: @asvetlov. (cherry picked from commit bb41147) Co-authored-by: Xtreak <tir.karthi@gmail.com>
asvetlov
pushed a commit
that referenced
this pull request
Sep 13, 2019
…make_cookies (GH-13921) (GH-16092) * [3.7] bpo-12144: Handle cookies with expires attribute in CookieJar.make_cookies (GH-13921) Handle time comparison for cookies with `expires` attribute when `CookieJar.make_cookies` is called. Co-authored-by: Demian Brecht <demianbrecht@gmail.com> https://bugs.python.org/issue12144 Automerge-Triggered-By: @asvetlov (cherry picked from commit bb41147) Co-authored-by: Xtreak <tir.karthi@gmail.com> * Use warnings module instead of test.support.check_no_warnings * [3.7] bpo-12144: Handle cookies with expires attribute in CookieJar.make_cookies (GH-13921) Handle time comparison for cookies with `expires` attribute when `CookieJar.make_cookies` is called. Co-authored-by: Demian Brecht <demianbrecht@gmail.com> https://bugs.python.org/issue12144 Automerge-Triggered-By: @asvetlov. (cherry picked from commit bb41147) Co-authored-by: Xtreak <tir.karthi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle time comparison for cookies with
expiresattribute whenCookieJar.make_cookiesis called.Co-authored-by: Demian Brecht demianbrecht@gmail.com
https://bugs.python.org/issue12144
Automerge-Triggered-By: @asvetlov