8000 bpo-37177: make IDLE's search dialogs transient by taleinat · Pull Request #13869 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-37177: make IDLE's search dialogs transient #13869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2019
Merged

bpo-37177: make IDLE's search dialogs transient #13869

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f4d8a31
make the search dialogs transient
taleinat Jun 6, 2019
a95e05d
update idle_test.test_searchbase.test_open_and_close accordingly
taleinat Jun 6, 2019
fad204d
add a NEWS entry
taleinat Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions Lib/idlelib/idle_test/test_searchbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import unittest
from test.support import requires
from tkinter import Tk
from tkinter import Text, Tk, Toplevel
from tkinter.ttk import Frame
from idlelib import searchengine as se
from idlelib import searchbase as sdb
Expand Down Expand Up @@ -47,14 +47,15 @@ def test_open_and_close(self):
# open calls create_widgets, which needs default_command
self.dialog.default_command = None

# Since text parameter of .open is not used in base class,
# pass dummy 'text' instead of tk.Text().
self.dialog.open('text')
toplevel = Toplevel(self.root)
self.addCleanup(toplevel.destroy)
text = Text(toplevel)
self.dialog.open(text)
self.assertEqual(self.dialog.top.state(), 'normal')
self.dialog.close()
self.assertEqual(self.dialog.top.state(), 'withdrawn')

self.dialog.open('text', searchphrase="hello")
self.dialog.open(text, searchphrase="hello")
self.assertEqual(self.dialog.ent.get(), 'hello')
self.dialog.close()

Expand Down
2 changes: 2 additions & 0 deletions Lib/idlelib/searchbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def open(self, text, searchphrase=None):
else:
self.top.deiconify()
self.top.tkraise()
self.top.transient(text.winfo_toplevel())
if searchphrase:
self.ent.delete(0,"end")
self.ent.insert("end",searchphrase)
Expand All @@ -66,6 +67,7 @@ def close(self, event=None):
"Put dialog away for later use."
if self.top:
self.top.grab_release()
self.top.transient('')
self.top.withdraw()

def create_widgets(self):
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/IDLE/2019-06-07-00-17-41.bpo-37177.voU6pQ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Properly 'attach' search dialogs to their main window so that they behave
like other dialogs and do not get hidden behind their main window.
0