8000 GH-136410: Faster side exits by markshannon · Pull Request #136411 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

GH-136410: Faster side exits #136411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
+333 −262
Open

GH-136410: Faster side exits #136411

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a281775
Faster side exits.
markshannon Jul 7, 2025
ec7f0e2
Fix copy-and-paste error
markshannon Jul 7, 2025
911520a
Check validity at start of trace
markshannon Jul 7, 2025
73832b2
Tidy up
markshannon Jul 8, 2025
a9297a0
Null test before use
markshannon Jul 8, 2025
47b53d1
Update asserts
markshannon < 8000 relative-time datetime="2025-07-08T09:59:00Z" class="no-wrap">Jul 8, 2025
2564d41
Properly fix assert
markshannon Jul 8, 2025
779bd7d
Don't make object immortal until it is fully initialized
markshannon Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix copy-and-paste error
  • Loading branch information
@markshannon
markshannon committed Jul 7, 2025
commit ec7f0e27b9f563d6c71c73932d686986492dfb17
8000
2 changes: 1 addition & 1 deletion Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1485,7 +1485,7 @@ _PyExecutor_GetColdExecutor(void)
// This is initialized to true so we can prevent the executor
// from being immediately detected as cold and invalidated.
cold->vm_data.warm = true;
if (_PyJIT_Compile(cold, cold->trace, length)) {
if (_PyJIT_Compile(cold, cold->trace, 1)) {
Py_DECREF(cold);
Copy link
Member
@Fidget-Spinner Fidget-Spinner Jul 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's immortal. Decrefing won't do anything. I think you mean to call the dealloc function on it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot. I think I need to move making it immortal to after it is fully created.

Py_FatalError("Cannot allocate core JIT code");
}
Expand Down
0