8000 bpo-35621: Support running subprocesses in asyncio when loop is executed in non-main thread by asvetlov · Pull Request #13630 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

bpo-35621: Support running subprocesses in asyncio when loop is executed in non-main thread #13630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 2, 2019
Merged

bpo-35621: Support running subprocesses in asyncio when loop is executed in non-main thread #13630

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
673bdb4
Work on
asvetlov May 28, 2019
ce3a5d3
Merge branch 'master' into multiloop-watcher
asvetlov May 28, 2019
2fc2737
Support subprocesses in threads
asvetlov May 28, 2019
60bdb45
Merge branch 'master' into multiloop-watcher
asvetlov May 29, 2019
75e0495
Fix typo in comment
asvetlov May 29, 2019
df1b1ba
Merge branch 'master' into multiloop-watcher
asvetlov May 30, 2019
2d2db05
Init MultiLoopChildWatcher in UnixEventLoopPolicy constructor
asvetlov May 30, 2019
5c9fc12
Merge branch 'master' into multiloop-watcher
asvetlov May 30, 2019
e2f59e8
Revert tests change
asvetlov May 30, 2019
eaea9f9
Work on
asvetlov May 30, 2019
798a7fb
Add ThreadedChildWatcher and make it default
asvetlov May 31, 2019
7ba175e
Add check for is_active()
asvetlov May 31, 2019
4ed22ba
Add new watcher classes to test suite
asvetlov May 31, 2019
318f5a0
Merge branch 'master' into multiloop-watcher
asvetlov Jun 1, 2019
4c464e7
Correctly close watcher in tests
asvetlov Jun 1, 2019
c07e3f3
Clarify text
asvetlov Jun 1, 2019
03fa4b9
Make checkers stricter
asvetlov Jun 2, 2019
fd56fc7
Add specific test for non-active watcher
asvetlov Jun 2, 2019
e7805a6
Fix typo
asvetlov Jun 2, 2019
e849af5
Fix comment 8000
asvetlov Jun 2, 2019
ae7f11d
Drop redundant check
asvetlov Jun 2, 2019
6fb36f2
Fix comment
asvetlov Jun 2, 2019
d071f19
Code cleanup
asvetlov Jun 2, 2019
de56eb9
Improve logging message
asvetlov Jun 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Improve logging message
  • Loading branch information
@asvetlov
asvetlov committed Jun 2, 2019
commit de56eb9c4b405fadcc33710341f55c1b397643f2
4 changes: 2 additions & 2 deletions Lib/asyncio/unix_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,7 +1207,7 @@ def _do_waitpid(self, expected_pid):
pid, exc_info=True)
else:
if loop.is_closed():
logger.warning("Loop %r that handles pid %r is gone", loop, pid)
logger.warning("Loop %r that handles pid %r is closed", loop, pid)
else:
if debug_log and loop.get_debug():
logger.debug('process %s exited with returncode %s',
Expand Down Expand Up @@ -1280,7 +1280,7 @@ def _do_waitpid(self, loop, expected_pid, callback, args):
expected_pid, returncode)

if loop.is_closed():
logger.warning("Loop %r that handles pid %r is gone", loop, pid)
logger.warning("Loop %r that handles pid %r is closed", loop, pid)
else:
loop.call_soon_threadsafe(callback, pid, returncode, *args)

Expand Down
0