-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-135552: Make the GC clear weakrefs later. #136189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nascheme
wants to merge
14
commits into
python:main
Choose a base branch
from
nascheme:gh-135552-wr-clear-later
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+280
−112
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
42abb05
Make the GC clear weakrefs later.
nascheme 17a4f9e
Remove inaccurate comment.
nascheme 12f0b5c
Run clear_weakrefs() with world stopped.
nascheme 2f3daba
Defer weakref clears only for ref
8000
s to classes.
nascheme 123bc25
Ensure weakrefs with callbacks are cleared early.
nascheme 496c0b1
Add NEWS.
nascheme 8a553d1
Add comment about wrlist iteration.
nascheme 01c882f
Merge 'origin/main' into gh-135552-wr-clear-later
nascheme 0060602
Merge 'origin/main' into gh-135552-wr-clear-later
nascheme 900022b
Revise NEWS.
nascheme 84bd123
Defer clear for weakrefs without callbacks.
nascheme bb29ea1
Add unit test for GH-132413.
nascheme 073409b
Add additional tests for weakref clearing.
nascheme 135223e
Revert unneeded changes to unit tests.
nascheme File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
Misc/NEWS.d/next/Core_and_Builtins/2025-07-03-06-04-42.gh-issue-135552.CbBQof.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
Fix a bug caused by the garbage collector clearing weakrefs too early. The | ||
weakrefs in the ``tp_subclasses`` dictionary are needed in order to correctly | ||
invalidate type caches (for example, by calling ``PyType_Modified()``). | ||
Clearing weakrefs before calling finalizers causes the caches to not be | ||
correctly invalidated. That can cause crashes since the caches can refer to | ||
invalid objects. Defer the clearing of weakrefs without callbacks until after | ||
finalizers are executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.