8000 gh-134584: Eliminate redundant refcounting from `_CALL_ISINSTANCE` by noamcohen97 · Pull Request #136077 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-134584: Eliminate redundant refcounting from _CALL_ISINSTANCE #136077

New issue < 8000 details-dialog class="Box Box--overlay d-flex flex-column anim-fade-in fast overflow-auto" aria-label="Sign up for GitHub">

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

gh-134584: Eliminate redundant refcounting from _CALL_ISINSTANCE #136077

wants to merge 6 commits into from
+166 −53

Conversation

noamcohen97
Copy link
Contributor
@noamcohen97 noamcohen97 commented Jun 28, 2025 •
edited 8000 by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 28, 2025
Open
32 tasks
@noamcohen97 noamcohen97 force-pushed the refcount-isinstance branch from 55119d3 to 6c04f67 Compare June 28, 2025 14:53
@noamcohen97 noamcohen97 marked this pull request as draft June 28, 2025 15:04
Fidget-Spinner
Fidget-Spinner reviewed Jun 28, 2025
View reviewed changes
Copy link
Member
@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sheesh. This is really good. You even handled the optimizer's constant propagation. Very cool!

We're blocked on Mark's TOS caching PR (see the main issue's comments), so we need to hold off on this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments

@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noamcohen97 @Fidget-Spinner
0