10000 gh-135993: Fix IPv6 bug in `set_ok_port` and `return_ok_port` by LamentXU123 · Pull Request #136076 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135993: Fix IP 8000 v6 bug in set_ok_port and return_ok_port #136076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

gh-135993: Fix IPv6 bug in set_ok_port and return_ok_port #136076

wants to merge 13 commits into from
+58 −4

Conversation

LamentXU123
Copy link
Contributor
@LamentXU123 LamentXU123 commented Jun 28, 2025 •
edited
Loading

Yet another IPv6 bug fix.

Instead of using the helper functions here, I've found a regex in the code, it looks like this:

cut_port_re = re.compile(r":\d+$", re.ASCII)

This could perfectly solve the bug. caz currently, we are doing this:

def request_port(request):
    host = request.host
    i = host.find(':')
    if i >= 0:
        port = host[i+1:]
        try:
            int(port)
        except ValueError:
            _debug("nonnumeric port: '%s'", port)
            return None
    else:
        port = DEFAULT_HTTP_PORT
    return port

And the problem is if the input is IPv6 addr like [::1]:1234, the program will treat :1]:1234 as a port and raise a ValueError when trying to int() it.

Now, since we've got the regex, we could use it directly in this func to make sure that port numbers can only be numbers and fix the bug.

Something like this:

def request_port(request):
    match = cut_port_re.search(request.host)
    if match:
        port = match.group(0).removeprefix(':')
        try:
            int(port)
        except ValueError:
            _debug("nonnumeric port: '%s'", port)
            return None
    else:
        port = DEFAULT_HTTP_PORT
    return port

I've also added the tests.

cc @picnixz . Looking forward to your review, thank you for your time and effort in advance.

📚 Documentation preview 📚: https://cpython-previews--136076.org.readthedocs.build/

@bedevere-app bedevere-app bot mentioned this pull request Jun 28, 2025
Open
@LamentXU123
Copy link
Contributor Author
LamentXU123 commented Jun 28, 2025 •
edited
Loading

Sorry for trying to merge the wrong branch. I'm fixing it.

Done now, sorry for the noise.

@LamentXU123 @StanFromIreland
Update Misc/NEWS.d/next/Library/2025-06-28-14-10-07.gh-issue-135993.G…
312f66f 
…myux9.rst

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LamentXU123 @StanFromIreland @picnixz
0