gh-67341: fix comment about windows link stat mapping #136049
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46c1b85 to
b64d3ae
Compare
|
Hello, thanks for your interest in contributing! I see that your prior PR, #136027, was accepted, but please don't use that as a green light to make several PRs fixing comment typos. These generally fall under the umbrella of "cosmetic changes", which we try to avoid. That said, this PR is already here, so we might as well use it. Are there any other comment fixes you would like to make? Let's do it all in one change, rather than many tiny changes; it's easier for us to handle from a review stance. After this one, please try to avoid sole comment changes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The above comment is written in 99d6135#diff-b5b7e4f5599916b2018e911ef423f9d3fd46cb71268e1a73c74a1c9ae2cb6791 commit, and
posixmodule.cincluded such logic at that time.The commit f2f373f which resolves #67341, moved the logic from
posixmodule.ctofileutils.c.This pull request includes only trivial changes but I've attached the GitHub issue number as a prefix, which I believe corresponds to Issue 23152 mentioned in the commit message. At the time, the contributors were using a separate tool outside of GitHub, so I thought it would be appropriate to match it with the bpo number listed in the issue description. Please let me know if there are any mistakes! Thank you.