8000
[3.14] gh-135755: rename undocumented HACL_CAN_COMPILE_SIMD{128,256} macros (GH-135847)
#136045
+67
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8,256}` macros (pythonGH-135847) Rename undocumented `HACL_CAN_COMPILE_SIMD{128,256}` macros to `_Py_HACL_CAN_COMPILE_VEC{128,256}`. These macros are private. (cherry picked from commit 1e975ae) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This was referenced Jun 27, 2025
|
Ok, so blake2module actually changed because of my recent refactor. I'm almost tempted to backport the refactor from blake2 to 3.14 as well because any changes in blake2 will lead to conflicts. OTOH, it's a long rewrite and I think it's better if we make manual backports in the future. I doubt we'll need to touch more those modules (I mean, they are pretty... stable in general). |
|
!buildbot FIPS only |
|
🤖 New build scheduled with the buildbot fleet by @picnixz for commit 25dabcd 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136045%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename undocumented
HACL_CAN_COMPILE_SIMD{128,256}macros to_Py_HACL_CAN_COMPILE_VEC{128,256}. These macros are private. (cherry picked from commit 1e975ae)