10000 gh-135755: Move SPECIAL_ constants to a private header by encukou · Pull Request #135922 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135755: Move SPECIAL_ constants to a private header #135922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

gh-135755: Move SPECIAL_ constants to a private header #135922

merged 1 commit into from
Jun 25, 2025

Conversation

encukou
Copy link
Member
@encukou encukou commented Jun 25, 2025 •
edited by bedevere-app bot
Loading

Macros without a Py/_Py prefix should not be defined in public headers.

These were added in #120640.

@encukou
pythongh-135755: Move SPECIAL_ constants to a private header
7c60af4 
Macros without a `Py`/`_Py` prefix should not be defined in public headers.
@bedevere-app bedevere-app bot mentioned this pull request Jun 25, 2025
Open
38 tasks
@encukou encukou added skip news needs backport to 3.14 bugs and security fixes labels Jun 25, 2025
@encukou encukou mentioned this pull request Jun 25, 2025
Merged
@encukou encukou merged commit 1b1ae82 into python:main Jun 25, 2025
55 checks passed
@encukou encukou deleted the special-names branch June 25, 2025 11:03
@miss-islington-app
Copy link

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1b1ae82fab0093924b8b89eb1c7eea11d7be7b18 3.14

@encukou
Copy link
Member Author
encukou commented Jun 25, 2025

Thanks for the review!

@bedevere-app
Copy link
bedevere-app bot commented Jun 25, 2025

GH-135926 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 25, 2025
encukou added a commit to encukou/cpython that referenced this pull request Jun 25, 2025
@encukou
[3.14] pythongh-135755: Move SPECIAL_ constants to a private header (p…
45c38cc 
…ythonGH-135922)

Macros without a `Py`/`_Py` prefix should not be defined in public headers.
(cherry picked from commit 1b1ae82)

Co-authored-by: Petr Viktorin <encukou@gmail.com>
encukou added a commit that referenced this pull request Jun 25, 2025
@encukou
[3.14] gh-135755: Move SPECIAL_ constants to a private header (GH-135922
a345fed 
) (GH-135926)

Macros without a `Py`/`_Py` prefix should not be defined in public headers.
(cherry picked from commit 1b1ae82)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

@encukou encukou

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@encukou @iritkatriel
0