8000 gh-134584: Eliminate redundant refcounting from _STORE_SUBSCR_LIST_INT by corona10 · Pull Request #135907 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-134584: Eliminate redundant refcounting from _STORE_SUBSCR_LIST_INT #135907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

gh-134584: Eliminate redundant refcounting from _STORE_SUBSCR_LIST_INT #135907

wants to merge 2 commits into from
+55 −9

Conversation

corona10
Copy link
Member
@corona10 corona10 commented Jun 25, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 25, 2025
Open
32 tasks
@corona10 corona10 changed the title gh-134584: Eliminate redundant refcounting from STORE_SUBSCR_LIST_INT gh-134584: Eliminate redundant refcounting from _STORE_SUBSCR_LIST_INT Jun 25, 2025
Fidget-Spinner
Fidget-Spinner reviewed Jun 25, 2025
View reviewed changes
Copy link
Member
@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 comments.

Python/bytecodes.c
DEAD(sub_st);
ss = sub_st;
PyStackRef_CLOSE(list_st);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go on the stack too, and become a normal POP_TOP.

Python/optimizer_bytecodes.c
@@ -567,6 +567,13 @@ dummy_func(void) {
value = PyJitRef_Borrow(sym_new_const(ctx, ptr));
}

op(_POP_TOP_INT, (value -- )) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this below _POP_TOP. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments

@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 will be requested when the pull request is marked ready for review tomasr8 is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corona10 @Fidget-Spinner
0