-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-134939: Fill Out the concurrent.interpreters Docs #135902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-134939: Fill Out the concurrent.interpreters Docs #135902
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if the double spaces were intended or not. so suggested some edits....
@auvipy I presume Eric is using emacs, the double spaces are fine and conform to many technical writing style guides IIRC. You will find many occurrences throughout out the docs. |
Interesting! Didn’t know that to be honest |
Using double space between sentences is fairly standard. Traditionally the practice was meant to introduce a stronger visual separation between sentences, to help readers identify the boundary. Using a single space is a relatively recent practice, one that reflects an assumption that the software which renders (lays out) the text, like a browser, will render the inter-sentence boundary sufficiently distinctly. However, in my experience that isn't what actually happens most of the time. (Plus, the same software could just as easily detect the double space and render it how it likes.) Furthermore, text editors in particular don't necessarily follow this practice. For example, I use a fixed-width font in my terminal. Ultimately, any time the the text is rendered naively this way, it presents a readability challenge. Thus, I avoid using a single space between sentences. |
Very, historically started when type writers where introduced :-) |
Running mostly involves switching to an interpreter (in the current | ||
thread) and calling a function in that execution context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like a reference to the "Runtime Components" section after #135944 is landed, regarding the OS thread?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Places like these are a large part of why I opened that issue. 😄
* :class:`float` | ||
* :class:`tuple` (of similarly supported objects) | ||
|
||
There is a small number of Python types that actually share mutable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a small number of Python types that actually share mutable | |
There are a small number of Python types that actually share mutable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The subject of the verb is "a small number", which is singular. Otherwise, I'd agree that "There are Python types that..." would be correct.
Co-authored-by: neonene <53406459+neonene@users.noreply.github.com>
Unless there are any major objections, I'd like to land this today;, I have a "multiple interpreters HOWTO" branch, on top of this change, that I want to put up for review. If there are little things to tweak, I think we can take care of that in a follow-up PR. |
📚 Documentation preview 📚: https://cpython-previews--135902.org.readthedocs.build/