8000 gh-133296: Publicly expose critical section API that accepts PyMutex by ngoldbaum · Pull Request #135899 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-133296: Publicly expose critical section API tha 8000 t accepts PyMutex #135899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

gh-133296: Publicly expose critical section API that accepts PyMutex #135899

wants to merge 5 commits into from

Conversation

ngoldbaum
Copy link
Contributor
@ngoldbaum ngoldbaum commented Jun 24, 2025 •
edited
Loading

xref gh-133296

See capi-workgroup/decisions#67 for a detailed proposal and vote from the C API workgroup.

I tagged this to be added for 3.15 but maybe @hugovk is willing to grant an exception so this lands in 3.14, since it's pretty straightforward and is new API so it shouldn't break anyone.

Docs preview: https://cpython-previews--135899.org.readthedocs.build/en/135899/c-api/init.html#python-critical-section-api

@ngoldbaum ngoldbaum requested a review from markshannon as a code owner June 24, 2025 17:31
@bedevere-app bedevere-app bot mentioned this pull request Jun 24, 2025
Open
colesbury
colesbury reviewed Jun 24, 2025
View reviewed changes
Copy link
Contributor
@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some small clarifications that the macros take PyMutex* as opposed to PyMutex.

colesbury
colesbury reviewed Jun 24, 2025
View reviewed changes
@ngoldbaum @colesbury
Apply suggestions from code review
6d987c7 
Co-authored-by: Sam Gross <colesbury@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury left review comments

@ZeroIntensity ZeroIntensity ZeroIntensity left review comments

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ngoldbaum @colesbury @ZeroIntensity
0