10000 gh-135906: Use _PyObject_CAST in internal CPython headers by clin1234 · Pull Request #135892 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135906: Use _PyObject_CAST in internal CPython headers #135892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

gh-135906: Use _PyObject_CAST in internal CPython headers #135892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b471043
Use _Py_STATIC_CAST in _Py_TryXGetStackRef
clin1234 Jun 24, 2025
e205e0a
Use _Py_STATIC_CAST in Include/internal/pycore_object.h
clin1234 Jun 24, 2025
de9016c
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 25, 2025
b54a5db
Use _PyObject_CAST in Include/internal/pycore_object.h
clin1234 Jun 25, 2025
7bbfa8c
Use _PyObject_CAST for one function
clin1234 Jun 25, 2025
62eb149
Update Misc/NEWS.d/next/C_API/2025-06-25-01-03-10.gh-issue-135906.UBr…
clin1234 Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Include/internal/pycore_object.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ static inline PyObject *
_Py_XGetRef(PyObject **ptr)
{
for (;;) {
PyObject *value = _Py_atomic_load_ptr(ptr);
PyObject *value = _PyObject_CAST(_Py_atomic_load_ptr(ptr));
if (value == NULL) {
return value;
}
Expand All @@ -629,7 +629,7 @@ _Py_XGetRef(PyObject **ptr)
static inline PyObject *
_Py_TryXGetRef(PyObject **ptr)
{
PyObject *value = _Py_atomic_load_ptr(ptr);
PyObject *value = _PyObject_CAST(_Py_atomic_load_ptr(ptr));
if (value == NULL) {
return value;
}
Expand Down
2 changes: 1 addition & 1 deletion Include/internal/pycore_stackref.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,7 @@ _Py_TryIncrefCompareStackRef(PyObject **src, PyObject *op, _PyStackRef *out)
static inline int
_Py_TryXGetStackRef(PyObject **src, _PyStackRef *out)
{
PyObject *op = _Py_atomic_load_ptr_relaxed(src);
PyObject *op = _PyObject_CAST( _Py_atomic_load_ptr_relaxed(src));
if (op == NULL) {
*out = PyStackRef_NULL;
return 1;
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/C_API/2025-06-25-01-03-10.gh-issue-135906.UBrCWq.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix compilation errors when compiling the internal headers with a C++ compiler.
Loading
0