8000 gh-135855: Fix `SystemError` when passing non-dict object to `_interpreters.set___main___attrs` by brianschubert · Pull Request #135856 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135855: Fix SystemError when passing non-dict object to _interpreters.set___main___attrs #135856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

gh-135855: Fix SystemError when passing non-dict object to _interpreters.set___main___attrs #135856

merged 2 commits into from
Jun 24, 2025

Conversation

brianschubert
Copy link
Member
@brianschubert brianschubert commented Jun 23, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Jun 23, 2025
Closed
@brianschubert brianschubert added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 23, 2025
sobolevn
sobolevn approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member
@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sergey-miryanov
sergey-miryanov reviewed Jun 24, 2025
View reviewed changes
ericsnowcurrently
ericsnowcurrently approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member
@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericsnowcurrently ericsnowcurrently merged commit 4e6f0d1 into python:main Jun 24, 2025
40 checks passed
@miss-islington-app
Copy link

Thanks @brianschubert for the PR, and @ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 24, 2025
@brianschubert @miss-islington
pythongh-135855: Raise TypeError When Passing Non-dict Object to `_in…
f9f1172 
…terpreters.set___main___attrs` (pythongh-135856)

(cherry picked from commit 4e6f0d1)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
@miss-islington-app
Copy link

Sorry, @brianschubert and @ericsnowcurrently, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4e6f0d116e9725efb2d8eb6c3274aa3c024a6fb4 3.13

@bedevere-app
Copy link
bedevere-app bot commented Jun 24, 2025

GH-135900 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 24, 2025
@ericsnowcurrently ericsnowcurrently added 3.13 bugs and security fixes needs backport to 3.13 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes 3.13 bugs and security fixes labels Jun 24, 2025
@miss-islington-app
Copy link

Thanks @brianschubert for the PR, and @ericsnowcurrently for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @brianschubert and @ericsnowcurrently, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4e6f0d116e9725efb2d8eb6c3274aa3c024a6fb4 3.13

@ericsnowcurrently
Copy link
Member

@brianschubert, would you mind manually creating a backport PR for 3.13?

ericsnowcurrently pushed a commit that referenced this pull request Jun 24, 2025
@miss-islington @brianschubert
[3.14] gh-135855: Raise TypeError When Passing Non-dict Object to `_i…
090a42b 
…nterpreters.set___main___attrs` (gh-135900)

(cherry picked from commit 4e6f0d1, AKA gh-135856)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
brianschubert added a commit to brianschubert/cpython that referenced this pull request Jun 24, 2025
@brianschubert
[3.13] pythongh-135855: Raise TypeError When Passing Non-dict Object …
d33628e 
…to `_interpreters.set___main___attrs` (pythongh-135856)

(cherry picked from commit 4e6f0d1)

Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
@bedevere-app
Copy link
bedevere-app bot commented Jun 24, 2025

GH-135903 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 24, 2025
ericsnowcurrently pushed a commit that referenced this pull request Jun 24, 2025
@brianschubert
[3.13] gh-135855: Raise TypeError When Passing Non-dict Object to `_i…
3e43628 
…nterpreters.set___main___attrs` (gh-135903)

(cherry picked from commit 4e6f0d1, AKA gh-135856)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergey-miryanov sergey-miryanov sergey-miryanov left review comments

@sobolevn sobolevn sobolevn approved these changes

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@blockchainGuru1018 blockchainGuru1018 blockchainGuru1018 approved these changes

Assignees

@ericsnowcurrently ericsnowcurrently

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@brianschubert @ericsnowcurrently @sergey-miryanov @sobolevn @blockchainGuru1018
0