8000 gh-135836: Fix IndexError in asyncio.create_connection with empty exceptions list by heliang666s · Pull Request #135845 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135836: Fix IndexError in asyncio.create_connection with empty exceptions list #135845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jul 1, 2025
Merged

gh-135836: Fix IndexError in asyncio.create_connection with empty exceptions list #135845

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ad7e39c
Fix IndexError in asyncio.create_connection with empty exceptions list
heliang666s Jun 23, 2025
a40961c
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 23, 2025
f432b3f
Fix NEWS entry for gh-135836 - correct function reference
heliang666s Jun 23, 2025
f37d9e3
Re-trigger CI
heliang666s Jun 23, 2025
40d4551
Address core dev feedback: use TimeoutError instead of OSError
heliang666s Jun 23, 2025
8e9a353
Merge branch 'python:main' into fix-asyncio-create-connection-indexerror
heliang666s Jun 29, 2025
0e2fb84
Add test asyncio.create_connection Happy Eyeballs empty exceptions an…
heliang666s Jun 29, 2025
f334cf1
Test asyncio.create_connection Happy Eyeballs empty exceptions and up…
heliang666s Jun 29, 2025
cb817c1
test: check for error message in test_create_connection_happy_eyeball…
heliang666s Jul 1, 2025
2b5e199
Merge branch 'main' into fix-asyncio-create-connection-indexerror
heliang666s Jul 1, 2025
45da4d2
test: fix test_create_connection_happy_eyeballs_empty_exceptions to b…
heliang666s Jul 1, 2025
99dffd9
Revert unintended change
heliang666s Jul 1, 2025
0fb0fcb
Update Lib/asyncio/base_events.py
heliang666s Jul 1, 2025
7181244
Update Lib/test/test_asyncio/test_base_events.py
heliang666s Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/asyncio/base_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,7 +1161,7 @@ async def create_connection(
raise ExceptionGroup("create_connection failed", exceptions)
if len(exceptions) == 1:
raise exceptions[0]
else:
elif len(exceptions) > 1:
# If they all have the 8000 same str(), raise one.
model = str(exceptions[0])
if all(str(exc) == model for exc in exceptions):
Expand All @@ -1170,6 +1170,9 @@ async def create_connection(
# the various error messages.
raise OSError('Multiple exceptions: {}'.format(
', '.join(str(exc) for exc in exceptions)))
else:
# No exceptions were collected, raise a generic connection error
raise OSError('create_connection failed')
finally:
exceptions = None

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-06-23-11-04-25.gh-issue-135836.-C-c4v.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed :exc:`IndexError` in ``asyncio.create_connection()`` that could occur when the Happy Eyeballs algorithm resulted in an empty exceptions list during connection attempts.
Loading
0