8000 gh-135773: have pyvenv.cfg without home key anchor a venv and deduce home by rickeylev · Pull Request #135831 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-13 10000 5773: have pyvenv.cfg without home key anchor a venv and deduce home #135831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

gh-135773: have pyvenv.cfg without home key anchor a venv and deduce home #135831

wants to merge 3 commits into from

Conversation

rickeylev
Copy link
Contributor
@rickeylev rickeylev commented Jun 23, 2025 •
edited by bedevere-app bot
Loading

This restores the 3.13 behavior where pyvenv.cfg without a home key still activates
a virtual environment. In such cases, home is typically found by reading the symlink
that venv's interpreter executable points to.

@rickeylev rickeylev requested a review from FFY00 as a code owner June 23, 2025 02:46
@bedevere-app bedevere-app bot mentioned this pull request Jun 23, 2025
Open
@ncoghlan
Copy link
Contributor

We're reverting an undocumented change to undocumented behaviour so I don't think we need NEWS entry here.

@FFY00 @zooba I'm inclined to approve this pending a proposal for official relative path support in 3.15+ so there's only one legacy workaround to consider.

@rickeylev
Copy link
Contributor Author

Thanks, @ncoghlan!

proposal for official relative path support

Let me know what I can do on this. I'm happy and very willing to file a FR, send a poc PR, gather and contact interested parties, and participate in PEP drafting and writing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees
No one assigned
Labels
awaiting review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rickeylev @ncoghlan
0