8000 gh-135801: Fix inaccurate module info for SyntaxWarnings during AST parsing by heliang666s · Pull Request #135829 · python/cpython · GitHub
[go: up one dir, main page]
Skip to content

gh-135801: Fix inaccurate module info for SyntaxWarnings during AST parsing #135829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

gh-135801: Fix inaccurate module info for SyntaxWarnings during AST parsing #135829

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d971dd5
Fix: Better module info for SyntaxWarnings during AST parsing
Jun 23, 2025
0deed9e
Fix SyntaxWarning deduplication with pseudo-filenames
Jun 23, 2025
4b05629
Fix SyntaxWarning deduplication with pseudo-filenames
Jun 23, 2025
423fae3
Add Unit Test
Jun 23, 2025
20c4390
Fix test_warnings failures in CI
Jun 23, 2025
3ddfa71
Fix: Correct ImportError and NameError in test_warnings
Jun 23, 2025
93b3bca
Merge branch 'main' into main
heliang666s Jun 23, 2025
15ab120
Merge branch 'python:main' into main
heliang666s Jun 29, 2025
8c9913e
Fix improves SyntaxWarning module information by directly deriving mo…
heliang666s Jun 30, 2025
0d87aff
Merge branch 'main' into main
heliang666s Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test_warnings failures in CI
  • Loading branch information
heliang committed Jun 23, 2025
commit 20c4390fb76ba946b706bf056dffc668ed14682b
9 changes: 6 additions & 3 deletions Lib/test/test_warnings/__init__.py
View file
Open in desktop
50C8
Original file line number Diff line number Diff line change
Expand Up @@ -771,9 +771,11 @@ def test_improper_input(self):
self.assertRaises(UserWarning, self.module.warn, 'convert to error')

def test_import_from_module(self):
script = support.script_helper.make_script('test_warnings_importer',
'import test.test_warnings.data.import_warning')
rc, out, err = assert_python_ok(script)
with support.temp_dir() as script_dir:
script = support.script_helper.make_script(script_dir,
'test_warnings_importer',
'import test.test_warnings.data.import_warning')
rc, out, err = assert_python_ok(script)
self.assertNotIn(b'UserWarning', err)

def test_syntax_warning_for_compiler(self):
Expand All @@ -794,6 +796,7 @@ def func(self):
self.assertEqual(out, b'')
# Check that we got a SyntaxError.
err = err.decode()
err = support.strip_ansi(err)
self.assertIn("""SyntaxError: "is" with 'int' literal. Did you mean "=="?""", err)
# Check that the filename in the traceback is correct.
self.assertIn(os.path.basename(script_name), err)
Expand Down
Loading
0